[SERVER-14367] De-inline HostAndPort type, and remove dependencies on networking components. Created: 26/Jun/14  Updated: 11/Jul/16  Resolved: 30/Jun/14

Status: Closed
Project: Core Server
Component/s: Networking
Affects Version/s: None
Fix Version/s: 2.7.3

Type: Improvement Priority: Major - P3
Reporter: Andy Schwerin Assignee: Andy Schwerin
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-14368 Move HostAndPort::isSelf to a free fu... Closed
Participants:

 Description   

Its methods, by and large, should be implemented in a C++ file, and they shouldn't depend on the networking components to function. A HostAndPort is the name of a process on a network, not a way to communicate with one.

This will facilitate testing and functional decomposition.



 Comments   
Comment by Githook User [ 30/Jun/14 ]

Author:

{u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}

Message: SERVER-14367 HostAndPort deinlining.

Moves bodies of most HostAndPort methods to hostandport.cpp. Also, removes
setPort() and toString(false), and a handful of unused methods.

Removes dead / anachronistic behavior.
Branch: master
https://github.com/mongodb/mongo/commit/12599c2b6797d1b7ec60f3a79fe12d67bc22c4e3

Comment by Githook User [ 30/Jun/14 ]

Author:

{u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}

Message: SERVER-14367 Preparation for removing some implicit conversion and other methods of HostAndPort.

The setPort and implicit conversion operators are going away. This path fixes their existing
users.
Branch: master
https://github.com/mongodb/mongo/commit/1a49d864f34812f73c10b8e0b30c15150cb6ca69

Generated at Thu Feb 08 03:34:37 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.