[SERVER-14374] Fix include-what-you-use fallout from de-inlining hostandport.h Created: 27/Jun/14  Updated: 11/Jul/16  Resolved: 27/Jun/14

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 2.7.3

Type: Improvement Priority: Major - P3
Reporter: Andy Schwerin Assignee: Andy Schwerin
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Participants:

 Description   

In order to clean up hostandport.h, it is necessary to fix the IWYY violations that were slipping by because of headers formerly included indirectly through hostandport.h. This primarily revolves around properly namespacing and including headers for mongoutils::str::*, and some std containers.



 Comments   
Comment by Githook User [ 27/Jun/14 ]

Author:

{u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}

Message: SERVER-14374 Include mongo/util/mongoutils/str.h as needed.

Previously, the affected files compiled because of indirect includes from hostandport.h
Branch: master
https://github.com/mongodb/mongo/commit/0fe44a581bcf3028ed5ddb31256ce5ce07d1f452

Comment by Githook User [ 27/Jun/14 ]

Author:

{u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}

Message: SERVER-14374 Include server_options.h as needed and apply the std:: namespace when missing.

Previously, the affected files compiled because of indirect includes from hostandport.h
Branch: master
https://github.com/mongodb/mongo/commit/cf9d8c3ff9733686326fa2a96cd654cd8be3818a

Comment by Githook User [ 27/Jun/14 ]

Author:

{u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}

Message: SERVER-14374 Include mongo/util/mongoutils/str.h as needed.

It was formerly included implicitly via hostandport.h.
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/c7ff1c3fb8240fb70231e22d7153179a8663882d

Generated at Thu Feb 08 03:34:38 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.