[SERVER-14374] Fix include-what-you-use fallout from de-inlining hostandport.h Created: 27/Jun/14 Updated: 11/Jul/16 Resolved: 27/Jun/14 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code |
| Affects Version/s: | None |
| Fix Version/s: | 2.7.3 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Andy Schwerin | Assignee: | Andy Schwerin |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Participants: |
| Description |
|
In order to clean up hostandport.h, it is necessary to fix the IWYY violations that were slipping by because of headers formerly included indirectly through hostandport.h. This primarily revolves around properly namespacing and including headers for mongoutils::str::*, and some std containers. |
| Comments |
| Comment by Githook User [ 27/Jun/14 ] |
|
Author: {u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}Message: Previously, the affected files compiled because of indirect includes from hostandport.h |
| Comment by Githook User [ 27/Jun/14 ] |
|
Author: {u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}Message: Previously, the affected files compiled because of indirect includes from hostandport.h |
| Comment by Githook User [ 27/Jun/14 ] |
|
Author: {u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}Message: It was formerly included implicitly via hostandport.h. |