[SERVER-14425] Lock manager correctness and performance Created: 02/Jul/14  Updated: 02/Aug/18  Resolved: 21/Oct/14

Status: Closed
Project: Core Server
Component/s: Concurrency
Affects Version/s: None
Fix Version/s: 2.7.8

Type: Task Priority: Critical - P2
Reporter: Ian Whalen (Inactive) Assignee: Kaloian Manassiev
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
Participants:

 Description   

A catch-all ticket to track commits related to the performance and correctness of the lock manager.



 Comments   
Comment by Githook User [ 04/Nov/14 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-14425: add 2 more update serializability tests
Branch: master
https://github.com/mongodb/mongo/commit/11235f26f7a6063860f8252766f2e28042fad1a9

Comment by Githook User [ 04/Nov/14 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-14425: fix WriteConflictException handling in multi-update
Branch: master
https://github.com/mongodb/mongo/commit/e189cb6dbb04b0f01f6024bcd9593ade1cd50e1f

Comment by Githook User [ 03/Nov/14 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-14425: rename DeadLockException to WriteConflictException
Branch: master
https://github.com/mongodb/mongo/commit/aa67a4e69eeb73fedc64f9a9588c2fa24cf8c6ab

Comment by Githook User [ 03/Nov/14 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-14425: make deadlock logging less spammy
Branch: master
https://github.com/mongodb/mongo/commit/ac3c439b9605bf01776c84ad8ed57a1dc60cae54

Comment by Githook User [ 31/Oct/14 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-14425: handle deadlocks in the middle up a multi-update
Branch: master
https://github.com/mongodb/mongo/commit/fd316bf9977f0109c288e3d8b298b9c6ac62bc70

Comment by Githook User [ 16/Oct/14 ]

Author:

{u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}

Message: SERVER-14425 fixed compilation error in fast_map_noalloc_test
Branch: master
https://github.com/mongodb/mongo/commit/1b3bc30c035aef041fec0b9cccf64e9f5640cf21

Comment by Githook User [ 16/Oct/14 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-14425 Move all Lock Manager enumerations to a separate header

Most of the lock manager enumeration types are necessary in places where
the entire lock manager interface and its structures are not needed.

Also causes circular include dependency with LockStats.
Branch: master
https://github.com/mongodb/mongo/commit/a2d6ac2d6cd8f15bcb9ac31535f114e028f0dd54

Comment by Githook User [ 16/Oct/14 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-14425 Avoid memory allocations in LockerImpl

Memory allocations on the common locking path in LockerImpl increase the
cost of uncontended lock operations and are fairly easy to be avoided through
keeping a stack of already allocated memory.
Branch: master
https://github.com/mongodb/mongo/commit/56947bfb0ef94a523c636833a6f76dc3c6880821

Comment by Githook User [ 16/Oct/14 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-14425 Implement map with no allocation for the lock manager tracking structures
Branch: master
https://github.com/mongodb/mongo/commit/58ba874afce49711be39f19352f9b6c35bb33de6

Comment by Githook User [ 13/Oct/14 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-14425 Fix a bug in the Lock Manager for the conversion path

The mode counts were not being maintained correctly and this was
introduced by commit 22b368a74b36896de6b164c55cd4b3b9ca562bb2.

This change also adds additional assertions to help catch such issues in
the future.
Branch: master
https://github.com/mongodb/mongo/commit/0bf559b47987c3fc4e4c5ce1b67b402a105422bd

Comment by Githook User [ 11/Oct/14 ]

Author:

{u'username': u'erh', u'name': u'Eliot Horowitz', u'email': u'eliot@10gen.com'}

Message: SERVER-14425 Add MMAP V1 check to invariant
Branch: master
https://github.com/mongodb/mongo/commit/a8aead0ac6e2fdcdb77cf8de738e6f5ed00b0545

Comment by Githook User [ 11/Oct/14 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-14425 Make MMAP V1 code in LockerImpl conditionally compiled

This change cuts down on the locking work that other storage engines have
to do.
Branch: master
https://github.com/mongodb/mongo/commit/7aa132c8087193f3efa23867b8783a0b7ad5a267

Comment by Githook User [ 11/Oct/14 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-14425 Performance optimization in LockManager for the unlock path
Branch: master
https://github.com/mongodb/mongo/commit/22b368a74b36896de6b164c55cd4b3b9ca562bb2

Comment by Githook User [ 11/Oct/14 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-14425 Cleanup LockerImpl

Comment by Githook User [ 10/Oct/14 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-14425 Fix memory leak in a unit-test and rename
Branch: master
https://github.com/mongodb/mongo/commit/894ef1bb9d8bff0e4cdaa81d17d113af868a4398

Comment by Githook User [ 10/Oct/14 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-14425 Remove ResourceId string copying in release builds
Branch: master
https://github.com/mongodb/mongo/commit/8239bdb62f317260ac993665a4a681d95124a91e

Comment by Githook User [ 10/Oct/14 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-14425 RIP LockState
Branch: master
https://github.com/mongodb/mongo/commit/2633025a73d8793d91d0049f4b5fafb26e22feb3

Comment by Githook User [ 10/Oct/14 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-14425 Move LockManager out of the newlm namespace
Branch: master
https://github.com/mongodb/mongo/commit/c868a14dfa6d1a926f38795a1273a7146cef6e77

Comment by Githook User [ 10/Oct/14 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-14425 Extract LockManager queue management logic to methods

Makes the code cleaner to read and reduces repeated sections.
Branch: master
https://github.com/mongodb/mongo/commit/fd09fb0f37c24c99d6c6b605702d580ace6a4250

Generated at Thu Feb 08 03:34:49 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.