[SERVER-14429] Don't modify ReplSettings object after startup Created: 02/Jul/14  Updated: 04/Dec/14  Resolved: 01/Dec/14

Status: Closed
Project: Core Server
Component/s: Internal Code, Replication
Affects Version/s: None
Fix Version/s: 2.8.0-rc2

Type: Task Priority: Major - P3
Reporter: Spencer Brody (Inactive) Assignee: Spencer Brody (Inactive)
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-14859 Remove HybridReplicationCoordinator Closed
is depended on by SERVER-14501 De-inline ReplSettings class Closed
Related
is related to SERVER-14420 Get rid of global replSettings object Closed
Backwards Compatibility: Fully Compatible
Participants:

 Comments   
Comment by Githook User [ 01/Dec/14 ]

Author:

{u'username': u'stbrody', u'name': u'Spencer T Brody', u'email': u'spencer@mongodb.com'}

Message: SERVER-14429 Make ReplSettings const now that it is no longer modified after startup
Branch: master
https://github.com/mongodb/mongo/commit/564e34cb9da16b13d7ee9eaf6ee3e7a57b7aad69

Comment by Spencer Brody (Inactive) [ 28/Aug/14 ]

We don't do this in the impl but we still do in the legacy so I'd like to leave this ticket open until we remove the legacy so we remember to make the accessor return a const-ref instead of a mutable ref

Comment by Eric Milkie [ 28/Aug/14 ]

Anything left for this one or is it complete?

Comment by Githook User [ 07/Aug/14 ]

Author:

{u'username': u'stbrody', u'name': u'Spencer T Brody', u'email': u'spencer@mongodb.com'}

Message: SERVER-14429 Don't change replSettings.fastsync after startup
Branch: master
https://github.com/mongodb/mongo/commit/7f42946e254d525697e58840d057c2bf3a0d93e2

Comment by Githook User [ 07/Aug/14 ]

Author:

{u'username': u'stbrody', u'name': u'Spencer T Brody', u'email': u'spencer@mongodb.com'}

Message: SERVER-14429 Don't change replSettings.master after startup
Branch: master
https://github.com/mongodb/mongo/commit/38572a2535ad1174d26af539d710068204ab3bc4

Generated at Thu Feb 08 03:34:50 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.