[SERVER-14476] JSTests::invokeLogError log check is still flawed Created: 07/Jul/14  Updated: 26/Jul/14  Resolved: 09/Jul/14

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: 2.7.4

Type: Bug Priority: Major - P3
Reporter: Mathias Stearn Assignee: Benety Goh
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-13460 JSTests::invokeLogError log check is ... Closed
Operating System: ALL
Participants:

 Description   

Follow-up to SERVER-13460. I think the solution has a race condition that prevents it from working correctly as the durThread may have already decided to do a DurParanoid run but not yet logged. Also we set DurParanoid to 0 after we attach the new appender.

Rather than fix the race condition, I'd suggest removing the code to futz with durOptions and instead just make the Tee only set _logged to true if logging from the same thread as that will solve the problem for all asynchronous logging, not just this one special case.

Associated build failure: https://mci.10gen.com/ui/task/mongodb_mongo_master_windows_64_debug_15b29e47fc909680de31c77513d3ab9a49738be0_14_07_07_08_27_06_dbtest_windows_64_debug

014-07-07T09:39:50.978+0000 [testsuite] going to run suite: js
2014-07-07T09:39:50.979+0000 [testsuite] 	 going to run test: class JSTests::BuiltinTests
2014-07-07T09:39:50.979+0000 [testsuite] 	 going to run test: class JSTests::BasicScope
2014-07-07T09:39:51.020+0000 [testsuite] 	 going to run test: class JSTests::ResetScope
2014-07-07T09:39:51.020+0000 [testsuite] 	 going to run test: class JSTests::FalseTests
2014-07-07T09:39:51.055+0000 [testsuite] 	 going to run test: class JSTests::SimpleFunctions
2014-07-07T09:39:51.105+0000 [testsuite] 	 going to run test: class JSTests::ExecLogError
2014-07-07T09:39:51.131+0000 [journal] DurParanoid map check 60ms for 160MB
2014-07-07T09:39:51.159+0000 [testsuite] FAIL: class JSTests::ExecLogError	Expected: !_logger.logged() @src\mongo\dbtests\jstests.cpp:196
2014-07-07T09:39:51.159+0000 [testsuite] 	 going to run test: class JSTests::InvokeLogError
2014-07-07T09:39:51.197+0000 [testsuite] ReferenceError: notAFunction is not defined



 Comments   
Comment by Githook User [ 09/Jul/14 ]

Author:

{u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}

Message: SERVER-14476 fixed LogRecordingScope to ignore log messages from background threads
Branch: master
https://github.com/mongodb/mongo/commit/7e8217417b3af161512169b5c32453401c1e7b96

Generated at Thu Feb 08 03:34:59 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.