[SERVER-14536] Helgrind suppressions for race-prone counters.cpp code Created: 11/Jul/14 Updated: 15/Aug/14 Resolved: 23/Jul/14 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Concurrency, Testing Infrastructure |
| Affects Version/s: | None |
| Fix Version/s: | 2.7.4 |
| Type: | Task | Priority: | Trivial - P5 |
| Reporter: | Kamran K. | Assignee: | Kamran K. |
| Resolution: | Done | Votes: | 0 |
| Labels: | 28qa, helgrind, pull-request | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Participants: | |||||||||
| Description |
|
Various methods in counters.cpp are prone to races, so it makes sense to add them to valgrind.suppressions. These OpCounters methods use the RARELY macro, which relies on a static counter that multiple threads can modify: OpCounters::gotCommand() And NetworkCounter::hit has this comment: // don't care about the race as its just a counter |
| Comments |
| Comment by Githook User [ 23/Jul/14 ] |
|
Author: {u'username': u'kkmongo', u'name': u'Kamran Khan', u'email': u'kamran.khan@mongodb.com'}Message: Closes #718 Signed-off-by: Benety Goh <benety@mongodb.com> |