[SERVER-14596] BSON escape() should take a StringData Created: 17/Jul/14  Updated: 19/Nov/16  Resolved: 08/Sep/16

Status: Closed
Project: Core Server
Component/s: JavaScript, Performance
Affects Version/s: None
Fix Version/s: 3.3.14

Type: Improvement Priority: Major - P3
Reporter: Eric Milkie Assignee: Matt Cotter
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Platforms 2016-09-19
Participants:

 Description   

SERVER-14592 precipitated this. In the code review, it was originally schwerin's recommendation to do this:
https://mongo-cr-archive.appspot.com/5151155143311360
Free function "escape()" in bsonelement.h should be moved to a better place and changed to take a StringData for efficiency, since its callers frequently provide it with string literals or other StringData variables.



 Comments   
Comment by Githook User [ 08/Sep/16 ]

Author:

{u'username': u'Machyne', u'name': u'Matt Cotter', u'email': u'matt.cotter@mongodb.com'}

Message: SERVER-14596 fix variable name
Branch: master
https://github.com/mongodb/mongo/commit/730dc4a5feb10426a38238769f7270c2f5f66ea1

Comment by Githook User [ 08/Sep/16 ]

Author:

{u'username': u'Machyne', u'name': u'Matt Cotter', u'email': u'matt.cotter@mongodb.com'}

Message: SERVER-14596 move free function escape out of bsonelement
Branch: master
https://github.com/mongodb/mongo/commit/383c6a87842a42a57abf2fc1dd8fd2724aadcb4f

Comment by Githook User [ 08/Sep/16 ]

Author:

{u'username': u'Machyne', u'name': u'Matt Cotter', u'email': u'matt.cotter@mongodb.com'}

Message: SERVER-14596 move free function escape out of bsonelement
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/27440f5882f389e04e595d071560f2995e390ccf

Generated at Thu Feb 08 03:35:22 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.