[SERVER-14734] Call SyncSourceFeedback::forwardSlaveProgress only once per replSetUpdatePositionCommand Created: 30/Jul/14 Updated: 19/Nov/14 Resolved: 27/Oct/14 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication |
| Affects Version/s: | None |
| Fix Version/s: | 2.8.0-rc0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Spencer Brody (Inactive) | Assignee: | Spencer Brody (Inactive) |
| Resolution: | Done | Votes: | 1 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Participants: |
| Description |
|
When we receive a replSetUpdatePositionCommand, it can contain progress updates for multiple nodes. We loop and call setLastOptime for each node with an update. Currently setLastOptime calls forwardSlaveProgress each time, potentially triggering more network round trips than necessary. Instead we should process all the updates, then call forwardSlaveProgress once at the end so we send one update with the information about all members |
| Comments |
| Comment by Githook User [ 27/Oct/14 ] |
|
Author: {u'username': u'stbrody', u'name': u'Spencer T Brody', u'email': u'spencer@mongodb.com'}Message: |