[SERVER-14992] Query for Windows 7 File Allocation Fix, and other hotfixes Created: 21/Aug/14 Updated: 15/Nov/21 Resolved: 09/Jan/15 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code |
| Affects Version/s: | None |
| Fix Version/s: | 2.6.9, 2.8.0-rc5 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Mark Benvenuto | Assignee: | Mark Benvenuto |
| Resolution: | Done | Votes: | 0 |
| Labels: | community-team, pull-request | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||||||
| Operating System: | Windows | ||||||||||||||||||||||||||||
| Backport Completed: | |||||||||||||||||||||||||||||
| Sprint: | Server 2.7.6 | ||||||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||||||
| Description |
|
We need to query Win32_QuickFixEngineering in WMI to get information about the installed KB articles Here is an example for the recent sync performance fix:
References: |
| Comments |
| Comment by Githook User [ 05/Mar/15 ] | ||
|
Author: {u'username': u'agherardi', u'name': u'agherardi', u'email': u'alessandro.gherardi@yahoo.com'}Message: Closes #924 Signed-off-by: Ramon Fernandez <ramon.fernandez@mongodb.com> | ||
| Comment by Ramon Fernandez Marina [ 12/Feb/15 ] | ||
|
Thanks for the pull request agherardi. I'm tentatively approving the backport for 2.6.9 pending a full test run. | ||
| Comment by Mark Benvenuto [ 09/Jan/15 ] | ||
|
Docs: We should ensure that we recommend customers install Microsoft KB 2731284 on Windows 7 & Windows 2008 R2 machines to get better file allocation performance for MMapV1 databases. | ||
| Comment by Mark Benvenuto [ 09/Jan/15 ] | ||
|
Yes, it is in 2.8. It will part of the next 2.8 rc release. | ||
| Comment by Alessandro Gherardi [ 09/Jan/15 ] | ||
|
Thanks, Mark. Is this patch going to make it into 2.8? | ||
| Comment by Githook User [ 09/Jan/15 ] | ||
|
Author: {u'username': u'agherardi', u'name': u'agherardi', u'email': u'alessandro.gherardi@yahoo.com'}Message: Closes #894 Signed-off-by: Mark Benvenuto <mark.benvenuto@mongodb.com> | ||
| Comment by Alessandro Gherardi [ 07/Jan/15 ] | ||
|
I updated the pull request per CR comments. Can the pull request be merged now? | ||
| Comment by Alessandro Gherardi [ 06/Jan/15 ] | ||
|
Mark - Any updates? Thanks, | ||
| Comment by Alessandro Gherardi [ 01/Jan/15 ] | ||
|
Created pull request: | ||
| Comment by Alessandro Gherardi [ 30/Dec/14 ] | ||
|
Hi Mark, Thanks, | ||
| Comment by Mark Benvenuto [ 30/Dec/14 ] | ||
|
Your change looks pretty good. I have a few minor suggestions though:
Thanks for all your work on this. | ||
| Comment by Alessandro Gherardi [ 30/Dec/14 ] | ||
|
Thanks, Mark. Without the MS hotfix and with tweaked code that never zeroes out data files, I could not reproduce the FlushViewOfFile error using dbtest, However, I could reproduce the error when creating a replicaset as mentioned in one of the posts in https://jira.mongodb.org/browse/SERVER-1459. Here's another patch that uses file version info: | ||
| Comment by Mark Benvenuto [ 29/Dec/14 ] | ||
|
I was afraid of the relying on the file version checks since I did not know if they documented how they version releases. After reviewing a few links, the KBs are coming off the LDR (limited distribution release) branch. Any KB contains all the previous changes for that file. I agree with your original suggestion. I think the best approach is now to check the file numbers by querying out VS_FIXEDFILEINFO from ntfs.sys. In terms of reproing it, the original bug suggested
You can build this executable if you run scons dbtest.exe. Let me know if you need any help, or if you would like me to finish this. | ||
| Comment by Alessandro Gherardi [ 29/Dec/14 ] | ||
|
Hi Mark, Regarding the alternative approach - file versioning. I cannot install http://support.microsoft.com/kb/2731284 on my Windows 7 laptop - the update installer says "The update is not applicable to your computer". I'm wondering if the reason is that the version of ntfs.sys on my laptop is 6.1.7601.22297. That's in the 6.1.7601.22xxx range and is already higher than the version that the updater would like to install - 6.1.7601.22083 (see File Information in http://support.microsoft.com/kb/2731284). If I disable zeroing out data files, is there an easy way to repro this issue https://jira.mongodb.org/browse/SERVER-1459? Thanks, | ||
| Comment by Mark Benvenuto [ 29/Dec/14 ] | ||
|
In terms of your tentative patch:
Your VARIANT usage is so simple that there is not much value for your ot switch to _variant_t. To contribute this, you will need to sign: http://www.mongodb.com/legal/contributor-agreement. See Contributing for general information. Thanks for your work on this. | ||
| Comment by Mark Benvenuto [ 29/Dec/14 ] | ||
|
We already know which hotfix to check for so that is enough. I let the Windows installer ensure we get the right version of the files we need. I do not know if we can rely on higher version numbers of files containing all the the fixes of previous versions or that file numbers are linearly increasing with respect to the fixes they contain. | ||
| Comment by Alessandro Gherardi [ 27/Dec/14 ] | ||
|
I have a question: Would checking the version of the file(s) updated by the hotfix be a better way to solve this problem? Specifically, for every file that the hotfix updates, we could check that the version of the file on disk is greater than or equal to the version contained in the hotfix. This approach is more reliable as often the same file is updated by multiple hotfixes. | ||
| Comment by Alessandro Gherardi [ 26/Dec/14 ] | ||
|
See https://github.com/agherardi/mongo/compare/mongodb:master...master for a tentative patch. |