[SERVER-1517] Turn on heapchecking in jstests on Linux 32 build Created: 30/Jul/10 Updated: 11/Dec/15 Resolved: 11/Dec/15 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Testing Infrastructure |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Alberto Lerner | Assignee: | DO NOT USE - Backlog - Test Infrastructure Group (TIG) |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Participants: | |||||||||
| Description |
|
Perhaps we could introduce google heap checker in our builds. Here's 1) Compile code with -fno-frame-omit-pointer 2) We link mongo, mongos, and mongod with tcmalloc 3) In shell_utils.cpp 4) Say we're monitoring leaks on mongos, e.g. we're running jstests/sharding/* 5) Instrument mongo::mutex::~mutex() as a false positive, so that |
| Comments |
| Comment by Andrew Morrow (Inactive) [ 11/Dec/15 ] |
|
Nope, feel free to close |
| Comment by Kamran K. [ 11/Dec/15 ] |
|
acm, is there value in trying to use HEAPCHECK with tcmalloc builds or should we close this now that we're using LSan with non-tcmalloc builds? |
| Comment by Alberto Lerner [ 01/Sep/10 ] |
|
The heap-checker, even in 1.6 (august release), is still presenting some problems in 64 bits. The problems have been reported in the perf-tools list, so I'm hoping eventually we'll get a fix. For now, 32 bits is pretty consistent and can be installed from packages. |
| Comment by Eliot Horowitz (Inactive) [ 01/Sep/10 ] |
|
Did you want to go 32 or 64 bit for this slave? |
| Comment by Alberto Lerner [ 13/Aug/10 ] |
|
No leaks detected in mongos in the sharding smoke tests. This is ready for the new build slave machine. |
| Comment by auto [ 12/Aug/10 ] |
|
Author: {'login': 'alerner', 'name': 'Alberto Lerner', 'email': 'alerner@10gen.com'}Message: |
| Comment by auto [ 10/Aug/10 ] |
|
Author: {'login': 'alerner', 'name': 'Alberto Lerner', 'email': 'alerner@10gen.com'}Message: |
| Comment by Alberto Lerner [ 10/Aug/10 ] |
|
Fix for last commit: Author: {'login': 'alerner', 'name': 'Alberto Lerner', 'email': 'alerner@10gen.com'}Message: Fix build (broken at f800c20958ba03e25e85) |
| Comment by auto [ 10/Aug/10 ] |
|
Author: {'login': 'alerner', 'name': 'Alberto Lerner', 'email': 'alerner@10gen.com'}Message: |
| Comment by auto [ 10/Aug/10 ] |
|
Author: {'login': 'alerner', 'name': 'Alberto Lerner', 'email': 'alerner@10gen.com'}Message: |
| Comment by auto [ 10/Aug/10 ] |
|
Author: {'login': 'alerner', 'name': 'Alberto Lerner', 'email': 'alerner@10gen.com'}Message: Revert " This reverts commit d607f3dcdcf97b1dc7fca59f94b36d8f21e1ee53. |
| Comment by auto [ 10/Aug/10 ] |
|
Author: {'login': 'alerner', 'name': 'Alberto Lerner', 'email': 'alerner@10gen.com'}Message: |
| Comment by auto [ 09/Aug/10 ] |
|
Author: {'login': 'alerner', 'name': 'Alberto Lerner', 'email': 'alerner@10gen.com'}Message: |
| Comment by Alberto Lerner [ 02/Aug/10 ] |
|
About 4), this is a no-op. Exit codes are already checked and., If heap-checking is activated and there's a leak, mongos exits through the heap-checker with an error exit code About 5), can be done by IgnoreObject after mutex alloc and UnIgnoreObject before mutex destruction, both within class mutex |