[SERVER-15184] Clang 3.5 reports error: memset overwrites vtable pointer in s2 Created: 09/Sep/14  Updated: 02/Oct/14  Resolved: 22/Sep/14

Status: Closed
Project: Core Server
Component/s: Geo
Affects Version/s: 2.7.6
Fix Version/s: 2.7.7

Type: Bug Priority: Major - P3
Reporter: Tyler Brock Assignee: Siyuan Zhou
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
duplicates SERVER-15304 Clang 3.5 reports error: "error: dest... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Participants:

 Description   

src/third_party/s2/s2regioncoverer.cc:116:10: error: destination for this 'memset' call is a pointer to class containing a dynamic class
      'S2Cell'; vtable pointer will be overwritten [-Werror,-Wdynamic-class-memaccess]
  memset(candidate, 0, size);
  ~~~~~~ ^
src/third_party/s2/s2regioncoverer.cc:116:10: note: explicitly cast the pointer to silence this warning
  memset(candidate, 0, size);
         ^
         (void*)
1 error generated.



 Comments   
Comment by Githook User [ 22/Sep/14 ]

Author:

{u'username': u'visualzhou', u'name': u'Siyuan Zhou', u'email': u'siyuan.zhou@mongodb.com'}

Message: SERVER-15184 memset before constructor to avoid clang 3.5 warning
Branch: master
https://github.com/mongodb/mongo/commit/556ef3433ea0dc8b43e67cfd178755a8034f2e14

Comment by Tyler Brock [ 22/Sep/14 ]

Works like a champ, thans Siyuan.

Comment by Githook User [ 19/Sep/14 ]

Author:

{u'username': u'TylerBrock', u'name': u'Tyler Brock', u'email': u'tyler.brock@gmail.com'}

Message: SERVER-15184 supress warning about memset overwriting vtable ptr
Branch: master
https://github.com/mongodb/mongo/commit/1c7e562f611f92cc4b6aec07eed4aacbee070155

Generated at Thu Feb 08 03:37:13 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.