[SERVER-15194] Make the base64::decode function throw for invalid input characters Created: 09/Sep/14 Updated: 06/Dec/17 Resolved: 06/Jul/17 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code |
| Affects Version/s: | 2.7.6 |
| Fix Version/s: | 3.5.10 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Andreas Nilsson | Assignee: | Sara Golemon |
| Resolution: | Done | Votes: | 0 |
| Labels: | neweng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Backwards Compatibility: | Minor Change | ||||
| Participants: | |||||
| Case: | (copied to CRM) | ||||
| Linked BF Score: | 0 | ||||
| Description |
|
base64::decode uasserts for invalid input lengths but not for invalid input characters. Extend this with a check for invalid base64 input characters. |
| Comments |
| Comment by Githook User [ 07/Jul/17 ] |
|
Author: {u'username': u'sgolemon', u'name': u'Sara Golemon', u'email': u'sara.golemon@mongodb.com'}Message: Unrevert 4b222edf455a34667cfaf7b67e7f8dfdca42bd9c and The good news is that the changes to base64::decode() |
| Comment by Githook User [ 07/Jul/17 ] |
|
Author: {u'username': u'ncm', u'name': u'Nathan Myers', u'email': u'ncm@cantrip.org'}Message: Revert " This reverts commit 4b222edf455a34667cfaf7b67e7f8dfdca42bd9c. |
| Comment by Sara Golemon [ 06/Jul/17 ] |
|
base64::decode() will now throw an exception on bad input whereas before it would quietly accept the bad input and produce garbage output. |
| Comment by Githook User [ 06/Jul/17 ] |
|
Author: {u'username': u'sgolemon', u'name': u'Sara Golemon', u'email': u'sara.golemon@mongodb.com'}Message:
Moved "Alphabet" class into cpp file in anon namespace Added base64::validate() method to accomodate BSON's |