[SERVER-15210] Remove undefined behavior from mongo::OID Created: 10/Sep/14 Updated: 02/Oct/14 Resolved: 22/Sep/14 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code |
| Affects Version/s: | None |
| Fix Version/s: | 2.7.7 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Andrew Morrow (Inactive) | Assignee: | Adam Midvidy |
| Resolution: | Done | Votes: | 0 |
| Labels: | pull-request | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||
| Participants: | |||||||||||||||||
| Description |
|
The implementation of mongo::OID relies on undefined behavior around alignment and aliasing. The makes OID unusable on architectures that require aligned reads/writes, or when building without -fno-strict-aliasing. |
| Comments |
| Comment by Githook User [ 25/Sep/14 ] |
|
Author: {u'username': u'mwhudson', u'name': u'Michael Hudson-Doyle', u'email': u'michael.hudson@linaro.org'}Message: fixes v8-3.25 build failure. Closes #793 Signed-off-by: Benety Goh <benety@mongodb.com> |
| Comment by Githook User [ 19/Sep/14 ] |
|
Author: {u'username': u'amidvidy', u'name': u'Adam Midvidy', u'email': u'amidvidy@gmail.com'}Message: Closes #784 Signed-off-by: Benety Goh <benety@mongodb.com> |