[SERVER-15210] Remove undefined behavior from mongo::OID Created: 10/Sep/14  Updated: 02/Oct/14  Resolved: 22/Sep/14

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 2.7.7

Type: Improvement Priority: Major - P3
Reporter: Andrew Morrow (Inactive) Assignee: Adam Midvidy
Resolution: Done Votes: 0
Labels: pull-request
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-15211 Make BSON serialization of mongo::OID... Closed
Related
related to SERVER-15382 Port mongo::OID endian fixes to v8-3.25 Closed
Backwards Compatibility: Fully Compatible
Participants:

 Description   

The implementation of mongo::OID relies on undefined behavior around alignment and aliasing. The makes OID unusable on architectures that require aligned reads/writes, or when building without -fno-strict-aliasing.



 Comments   
Comment by Githook User [ 25/Sep/14 ]

Author:

{u'username': u'mwhudson', u'name': u'Michael Hudson-Doyle', u'email': u'michael.hudson@linaro.org'}

Message: SERVER-15210 SERVER-15211 SERVER-15382 (v8-3.25) remove OID undefined behavior and make it endian aware.

fixes v8-3.25 build failure.

Closes #793

Signed-off-by: Benety Goh <benety@mongodb.com>
Branch: master
https://github.com/mongodb/mongo/commit/09fd21a206f959f6742e92d38b783a3e04e1948b

Comment by Githook User [ 19/Sep/14 ]

Author:

{u'username': u'amidvidy', u'name': u'Adam Midvidy', u'email': u'amidvidy@gmail.com'}

Message: SERVER-15210 SERVER-15211 remove OID undefined behavior and make it endian aware

Closes #784

Signed-off-by: Benety Goh <benety@mongodb.com>
Branch: master
https://github.com/mongodb/mongo/commit/78c5f9dd5ac65eae251df3e87175a0af076d90d9

Generated at Thu Feb 08 03:37:19 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.