[SERVER-15485] CanonicalQuery::canonicalize can leak a LiteParsedQuery Created: 01/Oct/14 Updated: 11/Mar/15 Resolved: 07/Oct/14 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Querying |
| Affects Version/s: | None |
| Fix Version/s: | 2.6.6, 2.7.8 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Andrew Morrow (Inactive) | Assignee: | J Rassi |
| Resolution: | Done | Votes: | 0 |
| Labels: | 28qa, address-sanitizer, leak-sanitizer, memory-leak | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Operating System: | ALL | ||||||||||||
| Backport Completed: | |||||||||||||
| Steps To Reproduce: | Run mongod under a leak detector, and run jstests/core/geo_s2near.js. The last line of that test, which tests a fix for |
||||||||||||
| Participants: | |||||||||||||
| Description |
|
If MatchExpressionParser::parse in the 13 argument form of CanonicalQuery::canonicalize throws an exception (as can occur, for instance, at uassert 17444 in expression_geo.cpp,) then the LiteParsedQuery object returned from LiteParsedQuery::make will be leaked since it is not wrapped in an owning smart pointer. |
| Comments |
| Comment by Githook User [ 25/Nov/14 ] |
|
Author: {u'username': u'jrassi', u'name': u'Jason Rassi', u'email': u'rassi@10gen.com'}Message: (cherry picked from commit 80baa49b5dff32bc0eebdfb2ab07d057126dea8d) |
| Comment by Githook User [ 07/Oct/14 ] |
|
Author: {u'username': u'jrassi', u'name': u'Jason Rassi', u'email': u'rassi@10gen.com'}Message: |