[SERVER-15700] Do not force index lookup during SortedDataInterface::unindex Created: 17/Oct/14  Updated: 25/Oct/14  Resolved: 17/Oct/14

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: 2.7.7
Fix Version/s: 2.7.8

Type: Improvement Priority: Minor - P4
Reporter: John Esmet Assignee: Unassigned
Resolution: Done Votes: 0
Labels: pull-request
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Participants:

 Description   

The current API to SortedDataInterface::unindex returns true if the desired index row was in fact deleted. This forces an internal lookup of the index row, which hurts performance, especially for write optimized storage engines.

We should simply not return anything from unindex().



 Comments   
Comment by Githook User [ 17/Oct/14 ]

Author:

{u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}

Message: SERVER-15700 SERVER-15701 fixed compilation error
Branch: master
https://github.com/mongodb/mongo/commit/1ee210fa58c2c9eb547095c1d26f8f080c6ec34f

Comment by Githook User [ 17/Oct/14 ]

Author:

{u'username': u'esmet', u'name': u'John Esmet', u'email': u'john.esmet@gmail.com'}

Message: SERVER-15700 Modify SortedDataInterface to not require unindex() to return
whether the index row was deleted. Fix unit tests to manually verify that
unindex() operations had the desired effect (in the same operation context)

Closes #827

Signed-off-by: Benety Goh <benety@mongodb.com>
Branch: master
https://github.com/mongodb/mongo/commit/a1b5c0925eedec72e402878433da4890630ef533

Generated at Thu Feb 08 03:38:43 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.