[SERVER-15705] (rocksdb) numRecords and numEntries to work with recovery unit Created: 17/Oct/14 Updated: 28/Apr/15 Resolved: 17/Oct/14 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Storage |
| Affects Version/s: | None |
| Fix Version/s: | 2.7.8 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Siying Dong | Assignee: | Eliot Horowitz (Inactive) |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||
| Issue Links: |
|
||||
| Operating System: | ALL | ||||
| Participants: | |||||
| Description |
|
In rocks engine, now numRecords and numEntries are not updated atomically in recovery unit commit time. This patch fix it by caching all the counter delta in rocks recovery unit and update time in commit, to both of memory and DB. Patch attached |
| Comments |
| Comment by Githook User [ 17/Oct/14 ] | ||||||||||||||||||||||||||||||||
|
Author: {u'username': u'siying', u'name': u'sdong', u'email': u'siying.d@fb.com'}Message: Signed-off-by: Benety Goh <benety@mongodb.com> | ||||||||||||||||||||||||||||||||
| Comment by Matt Kangas [ 17/Oct/14 ] | ||||||||||||||||||||||||||||||||
|
Tested atomic_counters_v2.patch, this fixes storage_rocks_sorted_data_impl_test but storage_rocks_engine_test fails
| ||||||||||||||||||||||||||||||||
| Comment by Siying Dong [ 17/Oct/14 ] | ||||||||||||||||||||||||||||||||
|
Forgot to mention atomic_counters_v2.patch is against 4e10def7b1ea9da02a5218d592073ff2587544cd | ||||||||||||||||||||||||||||||||
| Comment by Siying Dong [ 17/Oct/14 ] | ||||||||||||||||||||||||||||||||
|
Fix rocks_sorted_data_impl_test and the unused variable. atomic_counters_v2.patch uploaded. | ||||||||||||||||||||||||||||||||
| Comment by Siying Dong [ 17/Oct/14 ] | ||||||||||||||||||||||||||||||||
|
This should work. | ||||||||||||||||||||||||||||||||
| Comment by Siying Dong [ 17/Oct/14 ] | ||||||||||||||||||||||||||||||||
|
Still seems to be not working, trying to figure out how to format the patch. | ||||||||||||||||||||||||||||||||
| Comment by Siying Dong [ 17/Oct/14 ] | ||||||||||||||||||||||||||||||||
|
Re-post the patch. |