[SERVER-15901] Cleanup unused locks on the lock manager Created: 31/Oct/14  Updated: 19/Sep/15  Resolved: 10/Apr/15

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: 3.0.5, 3.1.2

Type: Bug Priority: Major - P3
Reporter: Kaloian Manassiev Assignee: Geert Bosch
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-18045 create global lock manager in a mongo... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Completed:
Sprint: Quint Iteration 3.1.1, Quint Iteration 3.1.2
Participants:
Linked BF Score: 0

 Description   

Currently for performance reasons the LM does not garbage-collect or reuse locks with no requests on them.

These eat up memory and need to be reclaimed periodically.



 Comments   
Comment by Githook User [ 14/Jul/15 ]

Author:

{u'username': u'GeertBosch', u'name': u'Geert Bosch', u'email': u'geert@mongodb.com'}

Message: SERVER-15901: Periodically cleanup unused lock heads

(cherry-picked from 8e6e1d78c4c170384e024747737c94542f9f60d3)
(cherry-picked from dd6c44de50bea877ab865fdb95aa3eeffce649b9)
(cherry-picked from 328aa5b207117e6ef09605b732ff94f782af5c36)

Conflicts:
src/mongo/db/concurrency/SConscript
Branch: v3.0
https://github.com/mongodb/mongo/commit/3abbc5ebb4f855220817545c993bf15a7f94a902

Comment by Geert Bosch [ 19/Jun/15 ]

We'll probably want to back port this to 3.0.x after SERVER-19054, which is trivial and should be done soon.

Comment by Githook User [ 14/Apr/15 ]

Author:

{u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}

Message: SERVER-15901 removed log message in LockManager::cleanupUnusedLocks()
Branch: master
https://github.com/mongodb/mongo/commit/dd6c44de50bea877ab865fdb95aa3eeffce649b9

Comment by Githook User [ 10/Apr/15 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-15901 Fix SSL build linkage dependency error
Branch: master
https://github.com/mongodb/mongo/commit/328aa5b207117e6ef09605b732ff94f782af5c36

Comment by Githook User [ 10/Apr/15 ]

Author:

{u'username': u'GeertBosch', u'name': u'Geert Bosch', u'email': u'geert@mongodb.com'}

Message: SERVER-15901: Periodically cleanup unused lock heads
Branch: master
https://github.com/mongodb/mongo/commit/8e6e1d78c4c170384e024747737c94542f9f60d3

Comment by Githook User [ 10/Apr/15 ]

Author:

{u'username': u'GeertBosch', u'name': u'Geert Bosch', u'email': u'geert@mongodb.com'}

Message: SERVER-15901: Correctly finalize the ThreadOstreamCache in unittests
Branch: master
https://github.com/mongodb/mongo/commit/174b36483d16bb2bdf2329ed5372710390ac7719

Comment by Daniel Pasette (Inactive) [ 09/Jan/15 ]

This has not shown to be a major issue in practice. There is a bit of extra memory usage, but would need an enormous number of locks to be impactful. Lowering priority.

Generated at Thu Feb 08 03:39:19 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.