[SERVER-16204] rocks storage engine should deal with nested recovery units correctly Created: 17/Nov/14  Updated: 28/Apr/15  Resolved: 19/Nov/14

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: 2.8.0-rc1

Type: Bug Priority: Major - P3
Reporter: Siying Dong Assignee: Matt Kangas
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-15744 RocksDB storage engine does not pass ... Closed
is depended on by SERVER-16604 Improve integration with rocks Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Participants:

 Description   

rocks storage now doesn't follow the protocol dealing nested recovery unit – "Inner UnitsOfWork neither commit nor rollback on their own but rely on the outermost to do it".



 Comments   
Comment by Siying Dong [ 19/Nov/14 ]

Thanks Matt Kangas! bench_test3.js fails because because we don't support document locking yet. We are still in discussion about how to deal with it for now.

Comment by Matt Kangas [ 19/Nov/14 ]

After this patch is applied, I still see bench_test3.js fails in jsCore and RollbackTests fails in dbtest. But this is definitely better than before.

Comment by Githook User [ 19/Nov/14 ]

Author:

{u'username': u'siying', u'name': u'sdong', u'email': u'siying.d@fb.com'}

Message: SERVER-16204 rocks storage engine should handle nested recovery units

Signed-off-by: Matt Kangas <matt.kangas@mongodb.com>
Branch: master
https://github.com/mongodb/mongo/commit/e6ff142766cf8cbfa04a9c6acc5cb8ced3ea9fb3

Comment by Matt Kangas [ 19/Nov/14 ]

Great. I have lots to work with here.

https://mci.10gen.com/task/rocksdb_ubuntu1404_rocksdb_2c7b356511a70c8e822a526f39a2ca9ad649e180_14_11_19_02_53_07_jsCore_ubuntu1404_rocksdb

Comment by Siying Dong [ 19/Nov/14 ]

jstests/core/indexa.js was one of them as a remember.

Probably most of the failure tests in this run: https://mci.10gen.com/task/rocksdb_ubuntu1404_rocksdb_4f740ca4fcfee9f0ec1c0a502e138ff749d5248d_14_11_17_21_13_06_jsCore_ubuntu1404_rocksdb

Comment by Matt Kangas [ 18/Nov/14 ]

Do we have an existing test which fails without this change?

Comment by Siying Dong [ 18/Nov/14 ]

It is now in branch rocks_nested_recovery_unit in mongodb-partners repro.

Comment by Siying Dong [ 17/Nov/14 ]

This is the commit I want to merge: https://github.com/mongodb-partners/mongo/commit/678563efeed6da07cc6e205f720533309ba6ed55

Generated at Thu Feb 08 03:40:18 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.