[SERVER-16431] Get rid of the ParallelBatchWriter mutex (aka "peanut-butter" lock) Created: 05/Dec/14 Updated: 06/Dec/22 Resolved: 16/Nov/16 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Replication, Storage |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Kaloian Manassiev | Assignee: | Backlog - Storage Execution Team |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Assigned Teams: |
Storage Execution
|
||||||||
| Participants: | |||||||||
| Description |
|
The ParallelBatchWriter lock needs to be acquired by each thread in both standalone and replicated instances. Now that the MMAP V1 journaling is split into global and flush locks, we can get rid of the PBR lock. The difference would be that the replication apply log coordinator will take the global lock in X mode before spawning the applier threads. Each applier thread then will not take the global lock (but will still take the flush lock in MMAP V1). |
| Comments |
| Comment by Eric Milkie [ 16/Nov/16 ] |
|
The ParallelBatchWriter is no longer a mutex but is a first class lockable resource. After conferring with Geert, we agreed that this work is no longer necessary, and that some day when secondary replication logic is replaced, it will go away on its own. |
| Comment by Githook User [ 15/Jan/15 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: |
| Comment by Githook User [ 09/Jan/15 ] |
|
Author: {u'username': u'jrassi', u'name': u'Jason Rassi', u'email': u'rassi@10gen.com'}Message: |
| Comment by Githook User [ 29/Dec/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: |
| Comment by Githook User [ 18/Dec/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: |
| Comment by Githook User [ 18/Dec/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: |
| Comment by Githook User [ 18/Dec/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: Also adds assertions and new tests. No functional changes yet - this is in |
| Comment by Githook User [ 17/Dec/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: Revert " This reverts commit c5ebc6be8e3a865655acbc5ecd1cb3b96fdf44ff. |
| Comment by Githook User [ 17/Dec/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: |
| Comment by Githook User [ 05/Dec/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: Not used anywhere. |
| Comment by Githook User [ 05/Dec/14 ] |
|
Author: {u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}Message: Allows us to get rid of the scoped lock chaining and pass on the |