[SERVER-16617] Performance regression has been introduced by f59a05c611d66a03c1fb8579b54569bfc2971374 Created: 20/Dec/14  Updated: 25/Dec/14  Resolved: 23/Dec/14

Status: Closed
Project: Core Server
Component/s: Performance, Write Ops
Affects Version/s: 2.8.0-rc3
Fix Version/s: 2.8.0-rc4

Type: Bug Priority: Blocker - P1
Reporter: Alvin Richards (Inactive) Assignee: Scott Hernandez (Inactive)
Resolution: Done Votes: 0
Labels: 28qa
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Backwards Compatibility: Fully Compatible
Operating System: ALL
Participants:

 Description   

Problem

An observed 87% performance regression has been introduced by f59a05c611d66a03c1fb8579b54569bfc2971374

Last good commit the throughput is

1b88ce0b469d85cff0575a6b0a98daa31a3f44e0
@@@START@@@
Update.MmsIncDeep1
	4	17675.90605543633
@@@END@@@

After this commit the throughput is

f59a05c611d66a03c1fb8579b54569bfc2971374
@@@START@@@
Update.MmsIncDeep1
	4	2314.1996434616813
@@@END@@@

The git bisect for this is as follows

f59a05c611d66a03c1fb8579b54569bfc2971374 is the first bad commit
commit f59a05c611d66a03c1fb8579b54569bfc2971374
Author: Scott Hernandez <scotthernandez@gmail.com>
Date: Fri Dec 5 11:15:41 2014 -0500

SERVER-15622: check parents in dotted paths during validation

:040000 040000 04cf9e7a4b79793f21d8d15234faa9e5d2abb45d fb62362f2ac1a8201d336393acc918c1b16f840d M jstests
:040000 040000 afc531a4380fa77458af2de2e64afafa527f7f1f aa6c6cb8e7fbd568426af6af9967d69b6bc16332 M src

Reproduce

var tests = []
load('mongo-perf/util/utils.js')
var setupMMS = function( collection ) {     
	collection.drop();      
	var base = { _id: 0, a: 0, h: {}, z: 0 };     
	for (var i = 0; i < 24; i++) {         
		base.h[i] = {};         
		for (var j = 0; j < 60; j++) {             
			base.h[i][j] = { n: 0, t: 0, v: 0 };         
		}     
	}     
	collection.insert(base); 
};
 
tests.push( { name: "Update.MmsIncDeep1",
			  tags: ['update','sanity','mms','daily','weekly','monthly'],               
			  pre: setupMMS,               
			  ops: [  { op:  "update", query: { _id: 0 }, update: { $inc: { "h.23.59.n": 1 } } } ] } );
 
runTests([4], 1, 8, 5, 1, 'test', 'sanity')



 Comments   
Comment by Githook User [ 23/Dec/14 ]

Author:

{u'username': u'scotthernandez', u'name': u'Scott Hernandez', u'email': u'scotthernandez@gmail.com'}

Message: SERVER-16617: respect deep during update validation
also includes some performance optimizations
Branch: master
https://github.com/mongodb/mongo/commit/b537713667249af6cf6c1fc289d5f1956ad78900

Generated at Thu Feb 08 03:41:41 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.