[SERVER-16659] Cleanup pass for CursorManager/getMore()/listCollections/listIndexes Created: 24/Dec/14  Updated: 02/Aug/18  Resolved: 20/Jan/15

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: 3.0.0-rc6

Type: Task Priority: Major - P3
Reporter: J Rassi Assignee: Gregory McKeon (Inactive)
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
is duplicated by SERVER-16047 listCollections silently ignores inva... Closed
Related
related to SERVER-16795 Recovery Unit invariant tripped when ... Closed
related to SERVER-16661 GlobalCursorIdCache leaks a SecureRandom Closed
Backwards Compatibility: Fully Compatible
Participants:

 Description   
  • Extend jstests for listCollections/listIndexes (test output format, the batchSize option, default batching, and killing/timeout if feasible).
  • Other commands that return cursors should use Command::appendCursorResponseObject() helper.
  • Change jstests invoking listCollections/listIndexes to not send "cursor: {}" option.
  • Wrap GlobalCursorIdCache::_secureCreate in owning smart pointer (fixes memory leak on shutdown). (covered by SERVER-16661)
  • Figure out if CursorManager::ns() should actually exist (consider also converting CursorManager into an interface, with a "collection" implementation and a "global" implementation, and unit test if feasible).
  • listIndexes output "cursor.ns" field should be "<database>.$cmd.listIndexes.<collection>".
  • Rename MockStage (new name: BufferedDataStage?).


 Comments   
Comment by Githook User [ 20/Jan/15 ]

Author:

{u'username': u'jrassi', u'name': u'Jason Rassi', u'email': u'rassi@10gen.com'}

Message: SERVER-16659 Add test to list_collections1.js
Branch: master
https://github.com/mongodb/mongo/commit/15867d511f3d6ae11a20899757de7e318e0acc05

Comment by Githook User [ 20/Jan/15 ]

Author:

{u'username': u'jrassi', u'name': u'Jason Rassi', u'email': u'rassi@10gen.com'}

Message: SERVER-16659 Expand coverage in list_indexes1.js
Branch: master
https://github.com/mongodb/mongo/commit/3cd12643d6941360e5b7b55a0caed75c82e541c5

Comment by Githook User [ 16/Jan/15 ]

Author:

{u'username': u'jrassi', u'name': u'Jason Rassi', u'email': u'rassi@10gen.com'}

Message: SERVER-16659 Expand coverage in list_collections1.js
Branch: master
https://github.com/mongodb/mongo/commit/bcf19d4af076b5ce4f760b43cbb770c8a941e8c4

Comment by Githook User [ 16/Jan/15 ]

Author:

{u'username': u'jrassi', u'name': u'Jason Rassi', u'email': u'rassi@10gen.com'}

Message: SERVER-16659 Better error detection when parsing cursor cmd requests
Branch: master
https://github.com/mongodb/mongo/commit/1e9f4211e895736973ed7ad1df296dd32f04052f

Comment by Githook User [ 15/Jan/15 ]

Author:

{u'username': u'jrassi', u'name': u'Jason Rassi', u'email': u'rassi@10gen.com'}

Message: SERVER-16659 listColls/listIndexes: empty cursor obj no longer needed
Branch: master
https://github.com/mongodb/mongo/commit/0aa409c0f7c1d65cf352e729e7b4787cfea20c23

Comment by Githook User [ 15/Jan/15 ]

Author:

{u'username': u'jrassi', u'name': u'Jason Rassi', u'email': u'rassi@10gen.com'}

Message: SERVER-16659 repairCursor/parallelCollScan use cursor response helper
Branch: master
https://github.com/mongodb/mongo/commit/6e7546ef5f1450321550441e83c33f99d96722ea

Comment by Githook User [ 12/Jan/15 ]

Author:

{u'username': u'jrassi', u'name': u'Jason Rassi', u'email': u'rassi@10gen.com'}

Message: SERVER-16659 Fix CursorManager/ClientCursorPin cosmetic issues

Const-correctness, comments.
Branch: master
https://github.com/mongodb/mongo/commit/e7c69c447f63564da9001ff59ce98d2cc82e87b9

Comment by Githook User [ 12/Jan/15 ]

Author:

{u'username': u'jrassi', u'name': u'Jason Rassi', u'email': u'rassi@10gen.com'}

Message: SERVER-16659 Better request/response parsing for cursor commands
Branch: master
https://github.com/mongodb/mongo/commit/95c60a44f94a2d8f090787a14dbdfbe96fdb97a3

Comment by Githook User [ 12/Jan/15 ]

Author:

{u'username': u'jrassi', u'name': u'Jason Rassi', u'email': u'rassi@10gen.com'}

Message: SERVER-16659 Collection: rename cursorManager() to getCursorManager()
Branch: master
https://github.com/mongodb/mongo/commit/9e1c94c0c9348f08bfa405896a28707afd62c899

Comment by Githook User [ 12/Jan/15 ]

Author:

{u'username': u'jrassi', u'name': u'Jason Rassi', u'email': u'rassi@10gen.com'}

Message: SERVER-16659 Rename MockStage to QueuedDataStage

It is no longer the case that this stage is only used for testing.
Branch: master
https://github.com/mongodb/mongo/commit/2468153c690dbe8312a10829d3cd7565ed90c1e1

Generated at Thu Feb 08 03:41:49 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.