[SERVER-16754] Confusing severity values when mongo shell start fails Created: 07/Jan/15 Updated: 18/Sep/15 Resolved: 15/Jan/15 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Logging, Shell |
| Affects Version/s: | 2.8.0-rc4 |
| Fix Version/s: | 3.0.0-rc6 |
| Type: | Bug | Priority: | Minor - P4 |
| Reporter: | Thomas Rueckstiess | Assignee: | Eric Milkie |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Operating System: | ALL | ||||||||
| Steps To Reproduce: | start "mongo" without a mongod running. |
||||||||
| Participants: | |||||||||
| Description |
|
When I start a mongo shell with 2.8.0-rc4 and no mongod is running, I get the following error:
The first line has severity W = Warning and the second line has severity I = Information. I'd expect both of these to be E = Error, although the first one is debatable, but the second one explicitly says "Error:". Additionally, I'd expect the second line not have the component QUERY, but also NETWORK instead. |
| Comments |
| Comment by Githook User [ 27/Jan/15 ] | |
|
Author: {u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}Message: Based on the following changes to engine_v8.h, engine_v8.cpp and v8_utils.cpp: (cherry picked from commit 107e3bfcd71936a876231517ee52aa6ca80b7e1d) | |
| Comment by Githook User [ 27/Jan/15 ] | |
|
Author: {u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}Message: Based on the following changes to engine_v8.h, engine_v8.cpp and v8_utils.cpp: | |
| Comment by Githook User [ 15/Jan/15 ] | |
|
Author: {u'username': u'milkie', u'name': u'Eric Milkie', u'email': u'milkie@10gen.com'}Message: | |
| Comment by Githook User [ 15/Jan/15 ] | |
|
Author: {u'username': u'milkie', u'name': u'Eric Milkie', u'email': u'milkie@10gen.com'}Message: | |
| Comment by Githook User [ 15/Jan/15 ] | |
|
Author: {u'username': u'milkie', u'name': u'Eric Milkie', u'email': u'milkie@10gen.com'}Message: | |
| Comment by Eric Milkie [ 07/Jan/15 ] | |
|
For Javascript exception messages, we don't actually know the underlying component generating the exception, so they will all have to be the same component. QUERY seemed more appropriate than CONTROL for Javascript log messages. We can change the exception message to be of severity E, but I am not inclined to change all the Javascript messages to be CONTROL. We should perhaps make a google doc to keep track of the severity and component changes for log messages throughout the server, as I expect that we will find many more of these | |
| Comment by Thomas Rueckstiess [ 07/Jan/15 ] | |
|
A similar issue with this line:
If it starts with "Error" then it should probably have severity E. Otherwise it's very confusing to users. |