[SERVER-16940] Change pass-by-ref of StringData to pass-by-value Created: 20/Jan/15  Updated: 18/Sep/15  Resolved: 11/Feb/15

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 3.1.0

Type: Improvement Priority: Major - P3
Reporter: Andrew Morrow (Inactive) Assignee: Tyler Brock
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Platform 00 2/20/15
Participants:

 Description   

Based on the investigations here:

http://stackoverflow.com/questions/27256377/c-view-types-pass-by-const-or-by-value/27260446#27260446

We have concluded that our idiomatic passing of StringData by const& is probably not correct.

We should re-write all 'const StringData&' to 'StringData.



 Comments   
Comment by Githook User [ 25/Feb/15 ]

Author:

{u'username': u'TylerBrock', u'name': u'Tyler Brock', u'email': u'tyler.brock@gmail.com'}

Message: SERVER-16940 Change pass-by-const-ref of StringData to pass-by-value

(cherry picked from commit bf990e6a399f2a05d2df801d59d06acde78083e5)
Branch: refs/tags/r2.6.8
https://github.com/10gen/mongo-enterprise-modules/commit/16feceee22fccb3e4d58255e5c0b5e8386be24cf

Comment by Githook User [ 24/Feb/15 ]

Author:

{u'username': u'TylerBrock', u'name': u'Tyler Brock', u'email': u'tyler.brock@gmail.com'}

Message: SERVER-16940 Change pass-by-const-ref of StringData to pass-by-value

(cherry picked from commit bf990e6a399f2a05d2df801d59d06acde78083e5)
Branch: refs/tags/r3.0.0-rc10
https://github.com/10gen/mongo-enterprise-modules/commit/16feceee22fccb3e4d58255e5c0b5e8386be24cf

Comment by Githook User [ 07/Feb/15 ]

Author:

{u'username': u'TylerBrock', u'name': u'Tyler Brock', u'email': u'tyler.brock@gmail.com'}

Message: SERVER-16940 Change pass-by-const-ref of StringData to pass-by-value
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/bf990e6a399f2a05d2df801d59d06acde78083e5

Comment by Githook User [ 06/Feb/15 ]

Author:

{u'username': u'TylerBrock', u'name': u'Tyler Brock', u'email': u'tyler.brock@gmail.com'}

Message: SERVER-16940 Change pass-by-const-ref of StringData to pass-by-value
Branch: master
https://github.com/mongodb/mongo/commit/aa9980b8c02de71c6918fba4aba9f22dd10eed01

Generated at Thu Feb 08 03:42:46 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.