[SERVER-16940] Change pass-by-ref of StringData to pass-by-value Created: 20/Jan/15 Updated: 18/Sep/15 Resolved: 11/Feb/15 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code |
| Affects Version/s: | None |
| Fix Version/s: | 3.1.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Andrew Morrow (Inactive) | Assignee: | Tyler Brock |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Sprint: | Platform 00 2/20/15 |
| Participants: |
| Description |
|
Based on the investigations here: http://stackoverflow.com/questions/27256377/c-view-types-pass-by-const-or-by-value/27260446#27260446 We have concluded that our idiomatic passing of StringData by const& is probably not correct. We should re-write all 'const StringData&' to 'StringData. |
| Comments |
| Comment by Githook User [ 25/Feb/15 ] |
|
Author: {u'username': u'TylerBrock', u'name': u'Tyler Brock', u'email': u'tyler.brock@gmail.com'}Message: (cherry picked from commit bf990e6a399f2a05d2df801d59d06acde78083e5) |
| Comment by Githook User [ 24/Feb/15 ] |
|
Author: {u'username': u'TylerBrock', u'name': u'Tyler Brock', u'email': u'tyler.brock@gmail.com'}Message: (cherry picked from commit bf990e6a399f2a05d2df801d59d06acde78083e5) |
| Comment by Githook User [ 07/Feb/15 ] |
|
Author: {u'username': u'TylerBrock', u'name': u'Tyler Brock', u'email': u'tyler.brock@gmail.com'}Message: |
| Comment by Githook User [ 06/Feb/15 ] |
|
Author: {u'username': u'TylerBrock', u'name': u'Tyler Brock', u'email': u'tyler.brock@gmail.com'}Message: |