[SERVER-16979] [Rocks] Correctly handle errors returned by RocksDB Created: 21/Jan/15  Updated: 06/Dec/22  Resolved: 12/Apr/19

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Minor - P4
Reporter: Igor Canadi Assignee: Backlog - Storage Execution Team
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-16604 Improve integration with rocks Closed
Assigned Teams:
Storage Execution
Participants:

 Description   

Currently when we get error from RocksDB we just do `invariant(false);`

I'm opening this issue to track all the places we need to fix this.



 Comments   
Comment by Githook User [ 23/Mar/15 ]

Author:

{u'username': u'igorcanadi', u'name': u'Igor Canadi', u'email': u'icanadi@fb.com'}

Message: SERVER-17706 Sync mongo-rocks with our recent changes

We've been developing these changes in a different repository. This
patch containes bunch of improvements and fixes:

  • Implement updateStatsAfterRepair()
  • Return correct ident size in getIdentSize() function
  • Fast drop operation in Mongo+Rocks
  • We should abort RocksTransaction when we do _releaseSnapshot()
  • SERVER-16979 Correctly handle errors returned by RocksDB
  • Implement StandardBulkBuilder and UniqueBulkBuilder
  • Add new option to RocksDB – rocksdbMaxWriteMBPerSec
  • Make oplog cleanup more efficient (also changes disk format)
  • Some configuration changes

Signed-off-by: Ramon Fernandez <ramon.fernandez@mongodb.com>
Branch: v3.0
https://github.com/mongodb/mongo/commit/12e24d4e910150d2523a226ba5a62370dc974d44

Generated at Thu Feb 08 03:42:53 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.