[SERVER-17068] 3.0.0-rc6 cannot build with the 3.25 JS engine Created: 27/Jan/15  Updated: 18/Sep/15  Resolved: 27/Jan/15

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: 3.0.0-rc6
Fix Version/s: 3.0.0-rc7

Type: Bug Priority: Major - P3
Reporter: Raffaele Rossi Assignee: Benety Goh
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-13686 support V8 3.25 JavaScript scripting ... Closed
Related
related to SERVER-16898 Support cross-compilation for MIPS Closed
is related to SERVER-13793 slow1/memory.js fails when building m... Closed
is related to SERVER-16754 Confusing severity values when mongo ... Closed
is related to SERVER-13256 Remove pch.h Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Steps To Reproduce:

scons --js-engine=v8-3.25 mongod

Participants:

 Description   

Build fails for when enabling V8-3.25 for the following reasons:

  1. missing std:: namespace
  2. missing boost:: namespace
  3. Erronous call to logger::globalLogDomain()->shouldLog()


 Comments   
Comment by Githook User [ 27/Jan/15 ]

Author:

{u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}

Message: SERVER-17068 fixed compilation errors

Based on the following changes to engine_v8.h, engine_v8.cpp and v8_utils.cpp:

SERVER-13256 Remove shared_ptr from pch.h
SERVER-13256 Add std namespace qualifications in headers
SERVER-13256 Add usings and qualifications for names from namespace std
SERVER-16754 correct shouldLog() to respect the current default component

(cherry picked from commit 107e3bfcd71936a876231517ee52aa6ca80b7e1d)
Branch: v3.0
https://github.com/mongodb/mongo/commit/a0986ff9cd64e935a37f4d0b254728712866c579

Comment by Githook User [ 27/Jan/15 ]

Author:

{u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}

Message: SERVER-17068 fixed compilation errors

Based on the following changes to engine_v8.h, engine_v8.cpp and v8_utils.cpp:

SERVER-13256 Remove shared_ptr from pch.h
SERVER-13256 Add std namespace qualifications in headers
SERVER-13256 Add usings and qualifications for names from namespace std
SERVER-16754 correct shouldLog() to respect the current default component
Branch: master
https://github.com/mongodb/mongo/commit/107e3bfcd71936a876231517ee52aa6ca80b7e1d

Comment by Benety Goh [ 27/Jan/15 ]

Hi raffopazzo, I'm taking care of the v8 compilation errors. You can pull my changes once they are in master.

Comment by Raffaele Rossi [ 27/Jan/15 ]

I signed the agreement and push my changes to my fork's master branch.
https://github.com/raffopazzo/mongo/commits/master

What should I do next?

Comment by Eric Milkie [ 27/Jan/15 ]

We'll take care of amending the commit message, but do reference "SERVER-17068" in the first line. And be sure to sign the contributor agreement if you haven't already: https://www.mongodb.com/legal/contributor-agreement

Comment by Raffaele Rossi [ 27/Jan/15 ]

Nope. This would be the first I actually contribute. Nobody aver pulled anything from me.
Any particular recommendation for the commit message? I saw that previous logs report the issue reference number SERVER-xxxxx

Comment by Eric Milkie [ 27/Jan/15 ]

Yes I think that should work. We've pulled from your fork before, correct?

Comment by Raffaele Rossi [ 27/Jan/15 ]

So I've got a fix ready. What shall I do? merge it back into my fork's master branch and submit a pull request from there?

Comment by Raffaele Rossi [ 27/Jan/15 ]

Please see https://jira.mongodb.org/browse/SERVER-16898 for more details

Generated at Thu Feb 08 03:43:11 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.