[SERVER-17068] 3.0.0-rc6 cannot build with the 3.25 JS engine Created: 27/Jan/15 Updated: 18/Sep/15 Resolved: 27/Jan/15 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Build |
| Affects Version/s: | 3.0.0-rc6 |
| Fix Version/s: | 3.0.0-rc7 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Raffaele Rossi | Assignee: | Benety Goh |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||||||||||||||||||
| Operating System: | ALL | ||||||||||||||||||||||||||||
| Steps To Reproduce: | scons --js-engine=v8-3.25 mongod |
||||||||||||||||||||||||||||
| Participants: | |||||||||||||||||||||||||||||
| Description |
|
Build fails for when enabling V8-3.25 for the following reasons:
|
| Comments |
| Comment by Githook User [ 27/Jan/15 ] |
|
Author: {u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}Message: Based on the following changes to engine_v8.h, engine_v8.cpp and v8_utils.cpp: (cherry picked from commit 107e3bfcd71936a876231517ee52aa6ca80b7e1d) |
| Comment by Githook User [ 27/Jan/15 ] |
|
Author: {u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}Message: Based on the following changes to engine_v8.h, engine_v8.cpp and v8_utils.cpp: |
| Comment by Benety Goh [ 27/Jan/15 ] |
|
Hi raffopazzo, I'm taking care of the v8 compilation errors. You can pull my changes once they are in master. |
| Comment by Raffaele Rossi [ 27/Jan/15 ] |
|
I signed the agreement and push my changes to my fork's master branch. What should I do next? |
| Comment by Eric Milkie [ 27/Jan/15 ] |
|
We'll take care of amending the commit message, but do reference " |
| Comment by Raffaele Rossi [ 27/Jan/15 ] |
|
Nope. This would be the first I actually contribute. Nobody aver pulled anything from me. |
| Comment by Eric Milkie [ 27/Jan/15 ] |
|
Yes I think that should work. We've pulled from your fork before, correct? |
| Comment by Raffaele Rossi [ 27/Jan/15 ] |
|
So I've got a fix ready. What shall I do? merge it back into my fork's master branch and submit a pull request from there? |
| Comment by Raffaele Rossi [ 27/Jan/15 ] |
|
Please see https://jira.mongodb.org/browse/SERVER-16898 for more details |