[SERVER-17223] Disable updateWithDamages support for RocksDB Created: 09/Feb/15 Updated: 25/Jan/17 Resolved: 10/Feb/15 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Storage |
| Affects Version/s: | None |
| Fix Version/s: | 3.0.0-rc9, 3.1.0 |
| Type: | Improvement | Priority: | Major - P3 |
| Reporter: | Igor Canadi | Assignee: | Benety Goh |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||||||
| Backport Completed: | |||||||||||||
| Participants: | |||||||||||||
| Description |
|
RocksDB doesn't really benefit from doing inplace update, so it's better to reroute updates through updateRecord(). One benefit of updateWithDamages() is that we have access to oldRecord, but hopefully we'll also get that information with updateRecord() as part of https://jira.mongodb.org/browse/SERVER-15793 |
| Comments |
| Comment by Ramon Fernandez Marina [ 19/Feb/15 ] |
|
NOTE: the backport to v3.0 for this fix was done as part of |
| Comment by Githook User [ 10/Feb/15 ] |
|
Author: {u'username': u'igorcanadi', u'name': u'Igor Canadi', u'email': u'icanadi@fb.com'}Message: Signed-off-by: Benety Goh <benety@mongodb.com> |
| Comment by Igor Canadi [ 10/Feb/15 ] |
|
This patch should also fix test failures casued by: https://github.com/mongodb/mongo/commit/570951951f752d1a31bb9e7f0d4276c1b533f25e |
| Comment by Igor Canadi [ 09/Feb/15 ] |
|
Here's the patch: https://github.com/mongodb-partners/mongo/tree/updatewithdamages |