[SERVER-17335] Add validation for WiredTiger index and collection options Created: 20/Feb/15 Updated: 05/Feb/16 Resolved: 14/Jul/15 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Storage, WiredTiger |
| Affects Version/s: | None |
| Fix Version/s: | 3.1.6 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Daniel Pasette (Inactive) | Assignee: | Max Hirschhorn |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Operating System: | ALL | ||||||||
| Sprint: | Quint 3.1.0, Quint Iteration 3.1.1, Quint Iteration 4, Quint Iteration 5, Quint Iteration 6 | ||||||||
| Participants: | |||||||||
| Description |
|
WiredTigerRecordStore::parseOptionsField and WiredTigerIndex::parseIndexOptions currently only check that storageEngine.wiredTiger.configString is a string. They should be changed to call wiredtiger_config_validate() and verify that the configuration is valid to pass to WT_SESSION::create. |
| Comments |
| Comment by Keith Bostic (Inactive) [ 09/Sep/15 ] | |||||||||||||||||||
|
ramon.fernandez, you are correct, the wiredtiger_config_validate functionality isn't present in the mongodb-3.0 branch of WT. wiredtiger_config_validate will be messy to backport to mongodb-3.0; it's not a complex or tricky change, but it's relatively big and a lot of files changed, it's not very self-contained. My understanding of this change was it wasn't a bug fix, it was an enhancement to do better error checking of configuration strings, is that causing problems for users? michael.cahill, FYI. | |||||||||||||||||||
| Comment by Githook User [ 14/Jul/15 ] | |||||||||||||||||||
|
Author: {u'username': u'visemet', u'name': u'Max Hirschhorn', u'email': u'max.hirschhorn@mongodb.com'}Message: | |||||||||||||||||||
| Comment by Githook User [ 14/Jul/15 ] | |||||||||||||||||||
|
Author: {u'username': u'visemet', u'name': u'Max Hirschhorn', u'email': u'max.hirschhorn@mongodb.com'}Message: | |||||||||||||||||||
| Comment by Keith Bostic (Inactive) [ 27/Apr/15 ] | |||||||||||||||||||
|
redbeard0531, I think this change is ready to be connected into MongoDB, can we talk through that work? | |||||||||||||||||||
| Comment by Keith Bostic (Inactive) [ 24/Apr/15 ] | |||||||||||||||||||
|
The changes in WiredTiger are complete and merged into the develop branch (see GitHub issue 1739 for details). For the record, there's a new function in WiredTiger, wiredtiger_config_validate, called as follows:
| |||||||||||||||||||
| Comment by Keith Bostic (Inactive) [ 07/Apr/15 ] | |||||||||||||||||||
|
dan@10gen.com, my mistake, I missed a connection. We're tracking this work in pull request 1739. michael.cahill, I'd like to review this change with you when you're back. | |||||||||||||||||||
| Comment by Keith Bostic (Inactive) [ 06/Apr/15 ] | |||||||||||||||||||
|
dan@10gen.com, can you point me to a writeup of what this API should do? |