[SERVER-17460] LIBDEPS_v8_SYSLIBDEP typo Created: 04/Mar/15  Updated: 18/Sep/15  Resolved: 05/Mar/15

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: 3.0.0
Fix Version/s: 3.0.1, 3.1.0

Type: Bug Priority: Minor - P4
Reporter: Marek Skalický Assignee: Ramon Fernandez Marina
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Backport Completed:
Steps To Reproduce:

scons all --use-system-all

Participants:

 Description   

MongoDB is failing to build. Problem is typographic error in srt/third_party/SConscript

There should be:
if use_system_version_of_library("v8"):
env['LIBDEPS_V8_SYSLIBDEP'] ])

instead of
env['LIBDEPS_v8_SYSLIBDEP'],

This change was done in this commit https://github.com/mongodb/mongo/commit/ef4f60e3951929a7b16cf8920216310ecc58cc49

If I change correct this MongoDB starts to build.



 Comments   
Comment by Githook User [ 05/Mar/15 ]

Author:

{u'username': u'omron93', u'name': u'Marek Skalick\xfd', u'email': u'mskalick@redhat.com'}

Message: SERVER-17460 LIBDEPS_v8_SYSLIBDEP typo

Closes #932

Signed-off-by: Ramon Fernandez <ramon@mongodb.com>
(cherry picked from commit 1383eaef74396e40e124c91746180df926e46a6a)
Branch: v3.0
https://github.com/mongodb/mongo/commit/63d223057c097a7324977adbb7a7d7e04ba4ac74

Comment by Githook User [ 05/Mar/15 ]

Author:

{u'username': u'omron93', u'name': u'Marek Skalick\xfd', u'email': u'mskalick@redhat.com'}

Message: SERVER-17460 LIBDEPS_v8_SYSLIBDEP typo

Closes #932

Signed-off-by: Ramon Fernandez <ramon@mongodb.com>
Branch: master
https://github.com/mongodb/mongo/commit/1383eaef74396e40e124c91746180df926e46a6a

Comment by Marek Skalický [ 04/Mar/15 ]

There is the pull request: https://github.com/mongodb/mongo/pull/932

Comment by Andrew Morrow (Inactive) [ 04/Mar/15 ]

Hi mskalick -

Thanks for the bug report. I agree with your suggested change. You are welcome to send a pull request against master if you already have the fix in your tree; you will need to sign the contributors agreement.

Also, please be aware that building with the system version of v8 may not work in general, as the v8 interfaces are not stable across releases. Additionally, there are runtime behavior changes in versions of v8 after 3.12 (the default vendored v8 version) that negatively affect the ability of mongod to control resource usage by the v8 runtime. This is why the default v8 version remains 3.12.

Thanks,
Andrew

Generated at Thu Feb 08 03:44:32 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.