[SERVER-17573] move collection creation OpObserver::onCreateCollection down into createCollection, et cetera Created: 12/Mar/15  Updated: 02/Dec/15  Resolved: 09/Apr/15

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 3.1.2

Type: Improvement Priority: Major - P3
Reporter: Eric Milkie Assignee: Matt Dannenberg
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-18078 logOp fassert when running mapReduce ... Closed
related to SERVER-15860 Switch replication metadata ops to be... Closed
is related to SERVER-21748 renameCollection command unnecessaril... Closed
is related to SERVER-17574 Pass mutablebson document into Collec... Closed
Backwards Compatibility: Fully Compatible
Sprint: RPL 1 04/03/15, RPL 2 04/24/15
Participants:

 Description   

To ensure no implicit collection creation forgets to explicitly log it in the oplog.
The observer will need to take no action if the collection is temporary or if the node is not a replset primary/master.



 Comments   
Comment by Githook User [ 09/Apr/15 ]

Author:

{u'username': u'dannenberg', u'name': u'matt dannenberg', u'email': u'matt.dannenberg@10gen.com'}

Message: SERVER-17573 move OpObserver calls into the datalayer as much as possible and eliminate repl bools
Branch: master
https://github.com/mongodb/mongo/commit/1725d76f448323a2bbaa11ffd37fd7b10cd6a64b

Comment by Eric Milkie [ 13/Mar/15 ]

Yes, it can be. The others are:
onDropCollection, move inside Database::dropCollection()
onInsert, move inside Collection::insertDocument()

Also, mr.cpp:460 I noticed is calling onInsert() but should be onCreateIndex().
We can consider how to streamline index creation later.

Comment by Andy Schwerin [ 12/Mar/15 ]

Can this be an umbrella ticket for moving all "operation observation" into the catalog objects, instead of having to know every time you do a catalog operation whether or not you have to log it? I suppose index creation might not fit well into this design, right now. Perhaps another thing to think about as we think about how we instruct the system to build indexes.

Generated at Thu Feb 08 03:44:56 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.