[SERVER-17790] Build third_party libraries with NDEBUG defined in optimized non-debug builds Created: 29/Mar/15  Updated: 07/Oct/15  Resolved: 28/Sep/15

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: None
Fix Version/s: 3.1.9

Type: Task Priority: Major - P3
Reporter: Andrew Morrow (Inactive) Assignee: Jonathan Reams
Resolution: Done Votes: 0
Labels: build-jbr
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-16496 override Boost's assert handler Closed
Backwards Compatibility: Fully Compatible
Sprint: Build 7 08/10/15, Build 8 08/31/15, Build 9 (09/18/15), Build A (10/09/15)
Participants:

 Description   

We don't globally define NDEBUG in the tree because we use our own macros to detect optimization or debugging.

Other libraries in third_party do reference NDEBUG in various ways, and expect it to be set correctly.

In particular, the following libraries make some sort of reference to NDEBUG:

  • boost-1.56
  • gperftools-2.2
  • pcre-8.30
  • s2
  • snappy-1.1.2
  • v8

We should enable NDEBUG for all of third party when appropriate. This most likely corresponds to the configuration where we are building with optimization on, and debugging off.



 Comments   
Comment by Githook User [ 28/Sep/15 ]

Author:

{u'username': u'jbreams', u'name': u'Jonathan Reams', u'email': u'jbreams@mongodb.com'}

Message: SERVER-17790 Define NDEBUG on non-debug builds
Branch: master
https://github.com/mongodb/mongo/commit/36d240b6c0ec3a84266084fe161aeca86e659563

Generated at Thu Feb 08 03:45:34 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.