[SERVER-17817] Consolidate Client, ClientBasic and ClientInfo into one type Created: 31/Mar/15  Updated: 25/Jan/17  Resolved: 20/Apr/15

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 3.1.2

Type: Bug Priority: Major - P3
Reporter: Andy Schwerin Assignee: Andy Schwerin
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Related
related to SERVER-25448 Replace all usages of ClientBasic wit... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Participants:
Linked BF Score: 0

 Description   

Via application of SERVER-17816 and other techniques. The goal is to have one type that represents a client session in any mongo server process.



 Comments   
Comment by Githook User [ 22/Apr/15 ]

Author:

{u'username': u'benety', u'name': u'Benety Goh', u'email': u'benety@mongodb.com'}

Message: SERVER-17817 SERVER-17894 Make Top a decoration on ServiceContext
Branch: master
https://github.com/mongodb/mongo/commit/14d3b48316f6e2ed075d01c3a9e7dcb28c0f2b63

Comment by Githook User [ 20/Apr/15 ]

Author:

{u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}

Message: SERVER-17817 Make ServiceContext create and manage Client objects.

Also, deduplicate Client::* method implementations, guard the identity of the
current CurOp of a Client with the Client's _mutex instead of the mutex guarding
the list of all clients.

Makes the currentClient object private to client.cpp, and all access to the
thread-bound client is now done with haveClient() and cc() free functions in the
mongo namespace.

Removes the vesitgal Client::shutdown() methods.
Branch: master
https://github.com/mongodb/mongo/commit/84c4b7d15c6b98c7bb648bc60ade93b6af62b129

Comment by Githook User [ 17/Apr/15 ]

Author:

{u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}

Message: SERVER-17817 Rename client_auth_session.cpp to auth_decorations.cpp
Branch: master
https://github.com/mongodb/mongo/commit/b085e20c6b387ee28c3b21f9402d5f917d2a253e

Comment by Githook User [ 16/Apr/15 ]

Author:

{u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}

Message: SERVER-17817 Remove ClientInfo class.
Branch: master
https://github.com/mongodb/mongo/commit/5ae0a2505ca14442ca6473b2d713be4e84958e6b

Comment by Githook User [ 16/Apr/15 ]

Author:

{u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}

Message: SERVER-17817 Make AuthorizationManager a decoration on ServiceContext.

While we're in there, make it a fatal error to call AuthorizationManager::set or AuthorizationSession::set twice on the same object.
Branch: master
https://github.com/mongodb/mongo/commit/aa303eb3b5898842a0f5730472413d2b2fdc0930

Comment by Githook User [ 16/Apr/15 ]

Author:

{u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}

Message: SERVER-17817 Make AuthorizationSession a decoration of ClientBasic.
Branch: master
https://github.com/mongodb/mongo/commit/eb8025a6ff2c3652a1f89ae513f7a4a98cd4e2ab

Comment by Githook User [ 16/Apr/15 ]

Author:

{u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}

Message: SERVER-17817 Make AuthenticationSession a decoration on ClientBasic, not a member.
Branch: master
https://github.com/mongodb/mongo/commit/a377aa8648de036659bbb4e67c8dfa030299718b

Comment by Githook User [ 16/Apr/15 ]

Author:

{u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}

Message: SERVER-17817 Make AuthorizationSession a decoration on ClientBasic.
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/a6d159597c55be289572dc6441adbc5764d5cb6f

Comment by Githook User [ 16/Apr/15 ]

Author:

{u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}

Message: SERVER-17817 Make ServiceContext decorable.
Branch: master
https://github.com/mongodb/mongo/commit/e5f3146ff48f654dd3883be1e62ee6f0a8549ee8

Comment by Githook User [ 14/Apr/15 ]

Author:

{u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}

Message: SERVER-17817 Unconditionally clean up CurOp stack, even during shut down.
Branch: master
https://github.com/mongodb/mongo/commit/02db7fa76fcb8254929e5a84e11123ce6113feeb

Comment by Githook User [ 13/Apr/15 ]

Author:

{u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}

Message: SERVER-17817 Move OpDebug function implementations to curop.cpp from client.cpp.

Also, make Client::shutdown have void return type, since nobody consults it.
Branch: master
https://github.com/mongodb/mongo/commit/9fd721875c698ecc1541662175e2febfd366e224

Comment by Githook User [ 07/Apr/15 ]

Author:

{u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}

Message: SERVER-17817 Use the mongod auth manager state manipulator in dbtest, not the mock one.
Branch: master
https://github.com/mongodb/mongo/commit/9f8c53d804d5c34056aec79e105cf1a1e6892784

Comment by Githook User [ 07/Apr/15 ]

Author:

{u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}

Message: SERVER-17817 Refix compile error involving using auto when defining static const members.
Branch: master
https://github.com/mongodb/mongo/commit/7a3718e87ec8793dbbd92c2dd2d1f52a07e59bba

Comment by Githook User [ 07/Apr/15 ]

Author:

{u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}

Message: SERVER-17817 Fix compile error that clang liked but gcc did not.
Branch: master
https://github.com/mongodb/mongo/commit/d551b8eab1ba7a0b32a4a69861b4e19edd2eb77a

Comment by Githook User [ 07/Apr/15 ]

Author:

{u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}

Message: SERVER-17817 Make CurOp a decoration of ClientBasic, not a member of Client.
Branch: master
https://github.com/mongodb/mongo/commit/6febdbaf542464bab747e3ab3ba49ad7b38acd8f

Comment by Githook User [ 07/Apr/15 ]

Author:

{u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}

Message: SERVER-17817 Split ClusterLastErrorInfo concept out of ClientInfo type and into its own header.

With this change, ClientInfo is an empty subclass of ClientBasic, and in mongos we decorate
ClientBasic objects with information needed to do sharded last-error operations.
Branch: master
https://github.com/mongodb/mongo/commit/7dc9a83e8be3446551297e746dad4f6d74b7dca2

Comment by Githook User [ 07/Apr/15 ]

Author:

{u'username': u'ehershey', u'name': u'Ernie Hershey', u'email': u'ernie.hershey@10gen.com'}

Message: Revert "Revert "SERVER-17817 Enterprise portion of changing how we construct AuthorizationSessions.""

This reverts commit fc2570c12f6b81630a89dd9949072b407b364b4d.
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/c0a3a8cd32cd433710f8b86f9196468b8bf20764

Comment by Githook User [ 07/Apr/15 ]

Author:

{u'username': u'ehershey', u'name': u'Ernie Hershey', u'email': u'ernie.hershey@10gen.com'}

Message: Revert "SERVER-17817 Enterprise portion of changing how we construct AuthorizationSessions."

This reverts commit e5ee4fd87a40d22320280af6fa0d70df8dc2e030.
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/fc2570c12f6b81630a89dd9949072b407b364b4d

Comment by Githook User [ 06/Apr/15 ]

Author:

{u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}

Message: SERVER-17817 Enterprise portion of changing how we construct AuthorizationSessions.
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/e5ee4fd87a40d22320280af6fa0d70df8dc2e030

Comment by Githook User [ 06/Apr/15 ]

Author:

{u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}

Message: SERVER-17817 When setting up ClientBasic, get AuthorizationSession object from AuthorizationManager.
Branch: master
https://github.com/mongodb/mongo/commit/7ea3fc90c6c1f175da1e76ff79b1e6ae09377141

Comment by Githook User [ 06/Apr/15 ]

Author:

{u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}

Message: SERVER-17817 Remove inoperative code from client.h/cpp
Branch: master
https://github.com/mongodb/mongo/commit/9e2cc1588f25f81983de48f2c69130203e325175

Comment by Githook User [ 06/Apr/15 ]

Author:

{u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}

Message: SERVER-17817 Make ClientInfo::get behave as get-or-create.

This is a placeholder behavior until ClientInfo is removed as a type.
Branch: master
https://github.com/mongodb/mongo/commit/aff3a45d27ef42bcbdd077edf59fcfa903c42e9e

Comment by Githook User [ 06/Apr/15 ]

Author:

{u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}

Message: SERVER-17817 Attach pointer to ServiceContext to ClientBasic.
Branch: master
https://github.com/mongodb/mongo/commit/453c0b526ae5ed429caab2b6970d452c8d405a85

Comment by Githook User [ 06/Apr/15 ]

Author:

{u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}

Message: SERVER-17817 Move Locker cache in Client onto a decoration.
Branch: master
https://github.com/mongodb/mongo/commit/b3ee68fcf2b20cb9846d98bbc0ec60c76f93bb0f

Comment by Githook User [ 06/Apr/15 ]

Author:

{u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}

Message: SERVER-17817 Move replication-specific data from Client into ReplClientInfo decoration.
Branch: master
https://github.com/mongodb/mongo/commit/90b7f774b818a1038cc525a9fca14207d8d5ff71

Comment by Githook User [ 01/Apr/15 ]

Author:

{u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}

Message: SERVER-17817 Remove ClientInfo::getRemote in favor of parent class's implementation.
Branch: master
https://github.com/mongodb/mongo/commit/b686c650a8dd627953a3a6687aac2df3dbcc4e59

Comment by Githook User [ 01/Apr/15 ]

Author:

{u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}

Message: SERVER-17817 Remove various dead code and data from ClientInfo.
Branch: master
https://github.com/mongodb/mongo/commit/827d70905cea7af29981a6a2a39dd1f3eb88b926

Comment by Githook User [ 31/Mar/15 ]

Author:

{u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}

Message: SERVER-17817 Get rid of dead Request::getClientInfo method.
Branch: master
https://github.com/mongodb/mongo/commit/13fa61d79360fe30c27b7d4f97a16fe8a51b6ae1

Generated at Thu Feb 08 03:45:41 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.