[SERVER-18017] clang 3.6.0 warns about overriding without using the override keyword, this prevents compilation Created: 13/Apr/15  Updated: 19/Sep/15  Resolved: 08/May/15

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: 3.1.1
Fix Version/s: 3.1.3

Type: Bug Priority: Major - P3
Reporter: Matt Dannenberg Assignee: Andrew Morrow (Inactive)
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Platform 3 05/15/15
Participants:

 Description   

sample output:

src/mongo/db/auth/authz_manager_external_state_mock.h:64:24: warning: 'findOne' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
        virtual Status findOne(OperationContext* txn,
                       ^
src/mongo/db/auth/authz_manager_external_state.h:166:24: note: overridden virtual function is here
        virtual Status findOne(OperationContext* txn,
                       ^
In file included from src/mongo/db/auth/sasl_authentication_session.cpp:43:
src/mongo/db/auth/authz_manager_external_state_mock.h:69:24: warning: 'query' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
        virtual Status query(OperationContext* txn,
                       ^
src/mongo/db/auth/authz_manager_external_state.h:175:24: note: overridden virtual function is here
        virtual Status query(OperationContext* txn,
                       ^



 Comments   
Comment by Githook User [ 10/Jul/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-18017 SERVER-17728 Suppres some new clang 3.6 warnings we don't like

(cherry picked from commit 1d9b83f16314cdb1e9da4b5c853870f10abb49df)
Branch: v3.0
https://github.com/mongodb/mongo/commit/9860f961ad50e6cb84bab14721ee4404ce0f4b68

Comment by Daniel Pasette (Inactive) [ 18/Jun/15 ]

removing from requested backports after discussion with Drew.

Comment by Githook User [ 08/May/15 ]

Author:

{u'username': u'acmorrow', u'name': u'Andrew Morrow', u'email': u'acm@mongodb.com'}

Message: SERVER-18017 SERVER-17728 Suppres some new clang 3.6 warnings we don't like
Branch: master
https://github.com/mongodb/mongo/commit/1d9b83f16314cdb1e9da4b5c853870f10abb49df

Generated at Thu Feb 08 03:46:18 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.