[SERVER-18131] Make LastError data part of Client, not thread-local Created: 20/Apr/15 Updated: 25/Jan/17 Resolved: 29/Apr/15 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code |
| Affects Version/s: | None |
| Fix Version/s: | 3.1.3 |
| Type: | Task | Priority: | Major - P3 |
| Reporter: | Andy Schwerin | Assignee: | Andy Schwerin |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Backwards Compatibility: | Fully Compatible | ||||||||
| Participants: | |||||||||
| Description |
|
The LastError object on a thread stores information about the last getLastError-compatible operation on the current thread. All other such information is stored in objects hanging off of the Client itself, and LastError should be no different. |
| Comments |
| Comment by Githook User [ 29/Apr/15 ] |
|
Author: {u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}Message: Makes LastError a decoration on Client. Removes behavior that was specific to |
| Comment by Githook User [ 23/Apr/15 ] |
|
Author: {u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}Message: Revert " This reverts commit 54c25da33ec7270295c8948f6a51376ec4fd278c and |
| Comment by Githook User [ 23/Apr/15 ] |
|
Author: {u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}Message: |
| Comment by Githook User [ 23/Apr/15 ] |
|
Author: {u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}Message: Makes LastError a decoration on Client. Removes behavior that was specific to |
| Comment by Githook User [ 20/Apr/15 ] |
|
Author: {u'username': u'andy10gen', u'name': u'Andy Schwerin', u'email': u'schwerin@mongodb.com'}Message: |
| Comment by Andy Schwerin [ 20/Apr/15 ] |
|
It should and will live past the operation context. The client lasts through many operations. It is the representation of an ordered sequence of commands or operations, which is the concept to which I believe last-error ought to be bound. |
| Comment by Scott Hernandez (Inactive) [ 20/Apr/15 ] |
|
Isn't there a problem with this as the LastError should last past the operation context and client so it can live past the user request until GLE is called to return it? Or is the final death throw of GLE? |