[SERVER-18153] Implement command repldata responses Created: 21/Apr/15  Updated: 05/Feb/16  Resolved: 26/Jun/15

Status: Closed
Project: Core Server
Component/s: Querying, Replication
Affects Version/s: None
Fix Version/s: 3.1.5

Type: Task Priority: Major - P3
Reporter: Eric Milkie Assignee: Matt Dannenberg
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-19010 support sending and receiving metadat... Closed
is depended on by SERVER-19831 Liveness detection for upstream membe... Closed
Backwards Compatibility: Fully Compatible
Sprint: RPL 4 06/05/15, RPL 5 06/26/16
Participants:

 Description   

Spec:
Repl response is included when requested via $replData field in OP_CMD metadata, or at the end of command args for legacy OP_QUERY $cmd-style commands. OpCommand downconvert code should take care of this automatically.

Repl response is provided for any command, including find and getmore commands. The response must be scheduled via the replication coordinator and fetch the data out of the topology coordinator.

The response data needs to be threaded into the metadata class (metadata.h). The metadata class cannot be linked to the replication system, so we will need a way to shuttle the information to it, possibly via the operation context.



 Comments   
Comment by Githook User [ 26/Jun/15 ]

Author:

{u'username': u'dannenberg', u'name': u'matt dannenberg', u'email': u'matt.dannenberg@10gen.com'}

Message: SERVER-18153 request and return replication metadata
Branch: master
https://github.com/mongodb/mongo/commit/0f59479a8dfdb310c2ccdc99ce6438ce3cbe41a6

Comment by Githook User [ 26/Jun/15 ]

Author:

{u'username': u'dannenberg', u'name': u'matt dannenberg', u'email': u'matt.dannenberg@10gen.com'}

Message: SERVER-18153 fix TopologyCoordnator access in prepareCursorResponseInfo
Branch: master
https://github.com/mongodb/mongo/commit/a7ed3d6c3e864c1bec25267ee02f6ead387f6647

Comment by Eric Milkie [ 29/May/15 ]

Added a spec with details to the description.

Comment by Andy Schwerin [ 29/May/15 ]

Two things:

  1. Cannot call _topologyCoordinator other than from the repl executor thread.
  2. This information should be attachable on any command response that requests it, not just cursor responses; this logic belongs in execCommand, and probably should go in metadata for OP_COMMAND executions.
Comment by Eric Milkie [ 27/Apr/15 ]

We need the request side to be complete in order to finish work on the responses.

Comment by Githook User [ 24/Apr/15 ]

Author:

{u'username': u'dannenberg', u'name': u'matt dannenberg', u'email': u'matt.dannenberg@10gen.com'}

Message: SERVER-18153 add repl subobject to find/getmore responses
Branch: master
https://github.com/mongodb/mongo/commit/1655e260f640dadc696684afb6766b86199a665b

Generated at Thu Feb 08 03:46:43 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.