[SERVER-18171] Rename various methods in RecoveryUnit Created: 22/Apr/15  Updated: 19/Sep/15  Resolved: 16/May/15

Status: Closed
Project: Core Server
Component/s: Storage
Affects Version/s: None
Fix Version/s: 3.1.3

Type: Improvement Priority: Minor - P4
Reporter: Geert Bosch Assignee: Geert Bosch
Resolution: Done Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Quint Iteration 3
Participants:

 Description   

commitAndRestart should be restartTransaction.
awaitCommit should be waitUntilDurable
goingToAwaitCommit should be goingToWaitUntilDurable



 Comments   
Comment by Githook User [ 18/May/15 ]

Author:

{u'username': u'GeertBosch', u'name': u'Geert Bosch', u'email': u'geert@mongodb.com'}

Message: SERVER-18171: Remove obsolete comment
Branch: master
https://github.com/mongodb/mongo/commit/2f458725a0c58adfab15126fef61b6ad1ff2c03b

Comment by Githook User [ 15/May/15 ]

Author:

{u'username': u'GeertBosch', u'name': u'Geert Bosch', u'email': u'geert@mongodb.com'}

Message: SERVER-18171: Rename awaitCommit to waitUntilDurable
Branch: master
https://github.com/mongodb/mongo/commit/5ff7104a1696494c38d80369bd9cda20bcbe973a

Comment by Githook User [ 15/May/15 ]

Author:

{u'username': u'GeertBosch', u'name': u'Geert Bosch', u'email': u'geert@mongodb.com'}

Message: SERVER-18171: Rename commitAndRestart to abandonSnapshot
Branch: master
https://github.com/mongodb/mongo/commit/44018783d2d0476ab7db9708ee98e14a2dd35f4e

Comment by Mathias Stearn [ 22/Apr/15 ]

restartTransaction is less than ideal since it doesn't actually "restart" anything. In fact it is illegal for an implementation to return while inside of a transaction. I propose either leaveTransaction() or abandonSnaphot(), will a preference for the latter since it expressions the actual intent of the method.

Generated at Thu Feb 08 03:46:47 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.