[SERVER-18236] Refactor metadata to use OP_COMMAND metadata object Created: 28/Apr/15  Updated: 24/Oct/19  Resolved: 16/Jun/15

Status: Closed
Project: Core Server
Component/s: None
Affects Version/s: None
Fix Version/s: 3.1.5

Type: Task Priority: Major - P3
Reporter: Adam Midvidy Assignee: Ian Whalen (Inactive)
Resolution: Done Votes: 0
Labels: todo_in_code
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-17607 Hook OP_COMMAND/OP_COMMANDREPLY into ... Closed
depends on SERVER-18664 Refactor command error handling Closed
is depended on by SERVER-18292 Re-enable all tests tagged with SERVE... Closed
Related
related to SERVER-44200 Collapse if statement in appendReplyM... Closed
related to SERVER-18515 Make OperationContext useful in mongos Closed
Backwards Compatibility: Fully Compatible
Sprint: Platform 4 06/05/15, Platform 5 06/26/16
Participants:

 Description   

Need to do: $gleStats, $impersonatedUsers, $impersonatedRoles, maxTimeMS, $readPreference, slaveOK

See the OP_COMMAND spec for further details



 Comments   
Comment by Githook User [ 16/Jun/15 ]

Author:

{u'username': u'amidvidy', u'name': u'Adam Midvidy', u'email': u'amidvidy@gmail.com'}

Message: SERVER-18236 cleanup ServerSelectionMetadata
Branch: master
https://github.com/mongodb/mongo/commit/be88e42ef819aeb76b8625e646adf67626844c25

Comment by Githook User [ 16/Jun/15 ]

Author:

{u'username': u'amidvidy', u'name': u'Adam Midvidy', u'email': u'amidvidy@gmail.com'}

Message: SERVER-18236 fix exception safety in generateErrorResponse
Branch: master
https://github.com/mongodb/mongo/commit/d124312c4c7d34678565a2607d13a016279b9893

Comment by Githook User [ 16/Jun/15 ]

Author:

{u'username': u'amidvidy', u'name': u'Adam Midvidy', u'email': u'amidvidy@gmail.com'}

Message: SERVER-18236 SERVER-18292 send impersonated users and roles via metadata object
Branch: master
https://github.com/mongodb/mongo/commit/4eb15b34d157e2719fc9034f5956b698d96ef64e

Comment by Githook User [ 16/Jun/15 ]

Author:

{u'username': u'amidvidy', u'name': u'Adam Midvidy', u'email': u'amidvidy@gmail.com'}

Message: SERVER-18236 send GLEStats over OP_COMMAND metadata object
Branch: master
https://github.com/mongodb/mongo/commit/2bf407c955f383a29d3d10fc6be273d9c6890961

Comment by Githook User [ 16/Jun/15 ]

Author:

{u'username': u'amidvidy', u'name': u'Adam Midvidy', u'email': u'amidvidy@gmail.com'}

Message: SERVER-18236 make runCommandHook and postRunCommand hook operate on the metadata object
Branch: master
https://github.com/mongodb/mongo/commit/b6b9e3ecd726bf9c36155e2dccd67f825a95800c

Comment by Githook User [ 16/Jun/15 ]

Author:

{u'username': u'amidvidy', u'name': u'Adam Midvidy', u'email': u'amidvidy@gmail.com'}

Message: SERVER-18292 SERVER-18236 read ReadPreference off of metadata in DBClientRS
Branch: master
https://github.com/mongodb/mongo/commit/5014f223f0692ca552858d04a5efe1958c3367fb

Comment by Githook User [ 16/Jun/15 ]

Author:

{u'username': u'amidvidy', u'name': u'Adam Midvidy', u'email': u'amidvidy@gmail.com'}

Message: SERVER-18236 provide variant of DBClientWithCommands::runCommands that
supports metadata
Branch: master
https://github.com/mongodb/mongo/commit/ac15ad101e966420991def6af1f90f89c7546e25

Comment by Githook User [ 16/Jun/15 ]

Author:

{u'username': u'amidvidy', u'name': u'Adam Midvidy', u'email': u'amidvidy@gmail.com'}

Message: SERVER-18236 SERVER-18292 send impersonated users and roles via metadata object
Branch: master
https://github.com/10gen/mongo-enterprise-modules/commit/58959abf153820d10413dcb317e47623c6b04314

Comment by Githook User [ 03/Jun/15 ]

Author:

{u'username': u'amidvidy', u'name': u'Adam Midvidy', u'email': u'amidvidy@gmail.com'}

Message: SERVER-18236 remove unused variable
Branch: master
https://github.com/mongodb/mongo/commit/db06d0a4ecdbac5b5e15981dd49c8a40ce74e255

Comment by Githook User [ 03/Jun/15 ]

Author:

{u'username': u'amidvidy', u'name': u'Adam Midvidy', u'email': u'amidvidy@gmail.com'}

Message: SERVER-18236 hang slaveOk/secondaryOk and readPreference off OpCtx

  • secondaryOk is upconverted/downconverted from QueryOption_SlaveOk
  • readPreference is upconverted/downconverted from $query wrapped commands or $queryOptions
  • both are now accessed via OperationContext instead of being read from a mutable command object
  • removed logic for parsing secondaryOk and readPreference from the command execution pipeline in dbcommands.cpp
    Branch: master
    https://github.com/mongodb/mongo/commit/b9ed79089841c5c05086a490c1323514f342bb42
Comment by Adam Midvidy [ 01/May/15 ]

This work will also include the shell helper requested by schwerin, which will be needed for testing.

It will be something like

DB.prototype.runCommandWithMetadata = function(command, cmdObj, metadataObj) {
....
}

Generated at Thu Feb 08 03:47:02 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.