[SERVER-18394] Remove smoke.py and unused modules from buildscripts/ directory Created: 08/May/15  Updated: 09/Mar/18  Resolved: 09/Mar/18

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: None
Fix Version/s: 3.7.3

Type: Task Priority: Major - P3
Reporter: Max Hirschhorn Assignee: Jonathan Abrahams
Resolution: Done Votes: 1
Labels: tig-resmoke
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
depends on SERVER-18392 Add README to buildscripts/ directory... Closed
depends on SERVER-18393 Add README to buildscripts/resmokecon... Closed
Related
is related to DOCS-5413 Instructions for running unittests ar... Closed
is related to SERVER-18389 Post-commit resmoke.py tasks Closed
Backwards Compatibility: Fully Compatible
Sprint: TIG 2018-03-26
Participants:

 Description   

MCI now runs all of the tasks using resmoke.py instead of smoke.py after the changes from SERVER-1424. We should remove smoke.py and any unnecessary code from the buildscripts/ directory.



 Comments   
Comment by Githook User [ 09/Mar/18 ]

Author:

{'email': 'jonathan@mongodb.com', 'name': 'Jonathan Abrahams', 'username': 'hptabster'}

Message: SERVER-18394 Remove smoke.py and unused modules from buildscripts/ directory
Branch: master
https://github.com/mongodb/mongo/commit/98eb87fdad21bbf1afa18bf887b30e2ac781314b

Comment by Max Hirschhorn [ 08/Mar/18 ]

The console_no_timestamps.yml logging configuration from my earlier comment should be added as a commit on this ticket. I believe Randolph has a version of it already locally but we might as well make it known to everyone as an option.

Comment by Jonathan Abrahams [ 08/Mar/18 ]

max.hirschhorn Do we want to implement console_no_timestamps as part of this work, as a separate ticket, or not at all?

Comment by Max Hirschhorn [ 14/May/17 ]

I think renctan has been the only holdout for completely switching to resmoke.py. After discussing with him in person, it came down to the annoyance of having a second timestamp (i.e. the one from resmoke.py) when running tests locally that use a MongoDB deployment started by MongoRunner. We should add another logging configuration that doesn't specify %(asctime)s in the tests' logger configuration so that python buildscripts/resmoke.py --log=console_no_timestamps can be used to run tests locally and not get a second timestamp in the output.

diff --git a/buildscripts/resmokeconfig/loggers/console_no_timestamps.yml b/buildscripts/resmokeconfig/loggers/console_no_timestamps.yml
new file mode 100644
index 0000000000..972b046102
--- /dev/null
+++ b/buildscripts/resmokeconfig/loggers/console_no_timestamps.yml
@@ -0,0 +1,13 @@
+logging:
+  executor:
+    format: '[%(name)s] %(asctime)s %(message)s'
+    handlers:
+      - class: logging.StreamHandler
+  fixture:
+    format: '[%(name)s] %(message)s'
+    handlers:
+      - class: logging.StreamHandler
+  tests:
+    format: '[%(name)s] %(message)s'
+    handlers:
+      - class: logging.StreamHandler

Comment by Eric Milkie [ 24/Feb/17 ]

I'm voting for this because we continue to make edits to this file as suites change, etc.
Alternatively, we do not make changes to this file, and it gets quickly out of sync with similar edits being made to resmoke. Neither of these options is very palatable.

Comment by Max Hirschhorn [ 08/May/15 ]

Should only remove smoke.py after we have added external documentation for using resmoke.py.

Generated at Thu Feb 08 03:47:32 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.