[SERVER-18567] ConnectionString::parse should return StatusWith<ConnectionString> Created: 19/May/15  Updated: 05/Feb/16  Resolved: 16/Jul/15

Status: Closed
Project: Core Server
Component/s: Networking
Affects Version/s: None
Fix Version/s: 3.1.6

Type: Task Priority: Major - P3
Reporter: Kaloian Manassiev Assignee: Kaloian Manassiev
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Duplicate
is duplicated by SERVER-8980 ConnectionString::parse on some inval... Closed
Backwards Compatibility: Fully Compatible
Participants:

 Description   

Currently ConnectionString::parse returns an invalid ConnectionString object if it fails and passes the message in a separate output parameter.

It should be changed to instead return StatusWith<ConnectionString> and the variant, which returns an invalid ConnectionString should be removed.



 Comments   
Comment by Githook User [ 16/Jul/15 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-18567 Remove legacy ConnectionString::parse

Removes the legacy ConnectionString::parse method and make all places use
the variant, which returns StatusWith<ConnectionString>.
Branch: master
https://github.com/mongodb/mongo/commit/ddffe2823221656e10844e7681c5bd766b74c21d

Comment by Githook User [ 16/Jul/15 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-18567 Move Future under the mongos commands

The future class and spawnCommand are only needed for sharding commands,
so this change moves them under cluster_commands_common.

Also moves setShardVersion to be under the version manager.

No functional changes.
Branch: master
https://github.com/mongodb/mongo/commit/ea73cdf50ede2622c9e005eb6e51cdc6ccb60650

Comment by Githook User [ 22/May/15 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-18567 Replace legacy ConnectionString::parse in MongoS startup
Branch: master
https://github.com/mongodb/mongo/commit/5ef166f8cb4820ff76943339f9df4e1f80e956b3

Comment by Githook User [ 22/May/15 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-18567 Replace usages of the legacy ConnectionString::parse

This is all the non-sharding code, which is using it.
Branch: master
https://github.com/mongodb/mongo/commit/eadabb492ee5e8ad8a37bb3aedd7d198c772da62

Comment by Githook User [ 21/May/15 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-18567 Implement ConnectionString::parse which returns StatusWith
Branch: master
https://github.com/mongodb/mongo/commit/70c7cba06315b14a92a4d46bf2244b990cda902b

Generated at Thu Feb 08 03:48:06 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.