[SERVER-18695] ElectionWinnerDeclarer::Algorithm::processResponse can call getValue() on non-OK StatusWith Created: 27/May/15  Updated: 19/Sep/15  Resolved: 28/May/15

Status: Closed
Project: Core Server
Component/s: Replication
Affects Version/s: None
Fix Version/s: 3.1.4

Type: Bug Priority: Major - P3
Reporter: Adam Midvidy Assignee: Matt Dannenberg
Resolution: Done Votes: 0
Labels: UT
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-18007 StatusWith should work with non-defau... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Steps To Reproduce:

apply patch from http://codereview.10gen.com/4650420190314496/ and run election_winner_declarer_test

Participants:

 Description   

Status cmdResponseStatus = getStatusFromCommandResult(response.getValue().data);                                                                                                                           
if (!response.isOK()) { // failed response                                                                                                                                                                 
    log() << "ElectionWinnerDeclarer: Got failed response from " << request.target                                                                                                                         
            << ": " << response.getStatus();                                                                                                                                                                 
}                                            

as part of SERVER-18007, this code will now invariant().



 Comments   
Comment by Githook User [ 28/May/15 ]

Author:

{u'username': u'dannenberg', u'name': u'matt dannenberg', u'email': u'matt.dannenberg@10gen.com'}

Message: SERVER-18695 do not call getValue on non-OK StatusWith in ElectionWinnerDeclarer::Algorithm::processResponse()
Branch: master
https://github.com/mongodb/mongo/commit/99a94133798eb8d3d812420246d0a97df4354df1

Generated at Thu Feb 08 03:48:28 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.