[SERVER-18815] Shard object lifetime shoud be managed by the ShardRegistry Created: 03/Jun/15  Updated: 05/Feb/16  Resolved: 12/Jun/15

Status: Closed
Project: Core Server
Component/s: Sharding
Affects Version/s: None
Fix Version/s: 3.1.5

Type: Task Priority: Major - P3
Reporter: Kaloian Manassiev Assignee: Daniel Alabi
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
related to SERVER-19929 Audit sharding code for potential use... Closed
Backwards Compatibility: Minor Change
Sprint: Sharding 4 06/05/15, Sharding 5 06/26/16
Participants:

 Description   

The Shard object should become the container for all shard connections, targeting and monitoring logic.

Thus, it should be made non-copyable and it's lifetime should be managed by the ShardRegistry.

A new type ShardId should be introduced, which will be used in all places which store Shard values currently.



 Comments   
Comment by Githook User [ 18/Jun/15 ]

Author:

{u'username': u'alabid', u'name': u'Daniel Alabi', u'email': u'alabidan@gmail.com'}

Message: SERVER-18815 Rename shard registry's findIfExists(...) to getShard(...) and avoid references to shared pointers to Shard object
Branch: master
https://github.com/mongodb/mongo/commit/e28994cc6aed7917f4a90d842686fd7c1eb21dd9

Comment by Githook User [ 09/Jun/15 ]

Author:

{u'username': u'alabid', u'name': u'Daniel Alabi', u'email': u'alabidan@gmail.com'}

Message: SERVER-18815 Make Shard object non-copyable. Get rid of Shard::make(...) and Shard::reset(...)
Branch: master
https://github.com/mongodb/mongo/commit/2cb47c5cd49f8a7427c618000da2f19c426fb9f6

Comment by Githook User [ 05/Jun/15 ]

Author:

{u'username': u'alabid', u'name': u'Daniel Alabi', u'email': u'alabidan@gmail.com'}

Message: SERVER-18815 Define ShardId type. Get rid of findIfExists(...) and getAllShards(...) methods on Shard object
Branch: master
https://github.com/mongodb/mongo/commit/7791d76b7466201a2e0c56ddadc9402d9be82c09

Comment by Githook User [ 04/Jun/15 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-18815 Remove Shard(std::string&) constructor

This change removes the shard constructor accepting std::string, since
shard creation should be explicit.
Branch: master
https://github.com/mongodb/mongo/commit/9ca45733c29190caa61b03b286e190ba3977b550

Generated at Thu Feb 08 03:48:49 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.