[SERVER-18826] Change query system variable names referring to DiskLoc to instead refer to RecordId Created: 04/Jun/15 Updated: 22/Feb/16 Resolved: 05/Feb/16 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Querying |
| Affects Version/s: | 3.3.1 |
| Fix Version/s: | 3.3.2 |
| Type: | Improvement | Priority: | Minor - P4 |
| Reporter: | David Storch | Assignee: | James Wahlin |
| Resolution: | Done | Votes: | 0 |
| Labels: | neweng | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Participants: |
| Description |
|
Query system code in the exec/ directory which predates the introduction of RecordId still has variable names which refer to DiskLoc. This is an MMAP-specific type, so we should update the variable names to refer to RecordId. For example, the enum values in WorkingSetMember::MemberState could be updated as follows:
Several PlanStages use 'loc' as variable name and need to be updated. For example: |
| Comments |
| Comment by Githook User [ 05/Feb/16 ] |
|
Author: {u'username': u'jameswahlin', u'name': u'James Wahlin', u'email': u'james.wahlin@10gen.com'}Message: Also renamed:
|
| Comment by David Storch [ 24/Jun/15 ] |
|
We should also consider renaming WorkingSetMember::OWNED_OBJ to WorkingSetMember::ONLY_OBJ or similar. |