[SERVER-18933] Resmoke doesn't honor --continueOnFailure in ASAN builds Created: 11/Jun/15  Updated: 05/Feb/16  Resolved: 12/Jun/15

Status: Closed
Project: Core Server
Component/s: Testing Infrastructure
Affects Version/s: 3.1.4
Fix Version/s: 3.1.5

Type: Bug Priority: Major - P3
Reporter: Jonathan Reams Assignee: Max Hirschhorn
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Quint Iteration 5
Participants:

 Description   

The issue is that resmokelib.errors.ServerFailure is considered fatal and converted into a StopExecution exception.

Proposal is to raise a TestFailure instead of a ServerFailure when the mongod is found to exit with a nonzero code when being restarted.

# Raise this after calling setup in case --continueOnFailure was specified.
if not teardown_success:
    raise errors.ServerFailure("%s did not exit cleanly" % (self.fixture))

The effect of this is that when LeakSanitizer causes the mongod to exit with code 23, we will mark the test that triggered the leak as having failed, but continue running the remaining tests.



 Comments   
Comment by Githook User [ 12/Jun/15 ]

Author:

{u'username': u'visemet', u'name': u'Max Hirschhorn', u'email': u'max.hirschhorn@mongodb.com'}

Message: SERVER-18933 Fix --continueOnFailure on ASAN builder.

A ServerFailure exception is always converted into a StopExecution
exception, whereas a TestFailure exception is only converted if
--continueOnFailure wasn't specified.
Branch: master
https://github.com/mongodb/mongo/commit/8d117a49d1f0ced022ea77267fadd30b498fb58a

Generated at Thu Feb 08 03:49:17 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.