[SERVER-1900] v8 Issue 708 Created: 06/Oct/10  Updated: 12/Jul/16  Resolved: 07/Oct/11

Status: Closed
Project: Core Server
Component/s: JavaScript
Affects Version/s: None
Fix Version/s: 2.1.0

Type: Bug Priority: Major - P3
Reporter: Aaron Staple Assignee: Antoine Girbal
Resolution: Done Votes: 2
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
is depended on by SERVER-2076 killall may fail in v8 Closed
is depended on by SERVER-387 currentOp() and killOp() don't work r... Closed
is depended on by SERVER-2407 Switch to v8 Closed
Operating System: ALL
Participants:

 Description   

This jira is a placeholder for v8 Issue 708. Until Issue 708 is fixed, GetCurrentThreadId() will only return the correct id for a thread if no v8 thread has been started between the start of the current v8 thread and the call to GetCurrentThreadId()

Our current implementation assumes Issue 708 has been fixed, a workaround for Issue 708 is possible but not ideal.



 Comments   
Comment by auto [ 15/Feb/12 ]

Author:

{u'login': u'agirbal', u'name': u'agirbal', u'email': u'antoine@10gen.com'}

Message: SERVER-4859: reenable SERVER-1900 checking in mr_killop.js test
Branch: master
https://github.com/mongodb/mongo/commit/462ea8a8b90c29b849026003319df31c86bed86e

Comment by Antoine Girbal [ 07/Oct/11 ]

Re-enabled tests, and tried with v8 r8669.
They now pass reliably, assuming this has been fixed then.

Comment by auto [ 06/Oct/11 ]

Author:

{u'login': u'agirbal', u'name': u'agirbal', u'email': u'antoine@10gen.com'}

Message: - SERVER-1900: v8 seems to be fixed. Reenabled both tests and it's passing now.
Branch: master
https://github.com/mongodb/mongo/commit/cade80c5d168253242127e35730d76874d0ee7ed

Comment by Eliot Horowitz (Inactive) [ 24/Aug/11 ]

@Ben - we're not looking at v8 again until after 2.0 ships.
At that point we'll re-consider if we want to switch, so it'll be another month or so.

Comment by Ben gamari [ 24/Aug/11 ]

Ping.

Comment by Ben gamari [ 23/Jul/11 ]

Judging by the fact that GetCurrentThreadId has been reworked around the Isolate class, there is a good chance this issue is fixed upstream.

Comment by Eliot Horowitz (Inactive) [ 14/Dec/10 ]

submit patch to v8

Comment by Aaron Staple [ 12/Oct/10 ]

Issue 708 was filed in May 2010, and none of the v8 developers have commented on the issue since it was created. Last week I commented with a starting point for a potential fix, and there have been no responses.

If we are interested in resolving SERVER-1900 in a timely fashion, we could consider either of the following:

1) Submit a proper v8 patch and hope it is accepted
2) Implement a workaround for Issue 708 - the first time we grab a v8 lock for a new thread we would cache the thread id. Not a lot of work, but not ideal since the v8 fix would be a simpler solution.

As a reminder, SERVER-1900 is blocking SERVER-387 in v8 mode.

Comment by Eliot Horowitz (Inactive) [ 07/Oct/10 ]

put here since we're blocking on v8 change

Comment by auto [ 06/Oct/10 ]

Author:

{'login': 'astaple', 'name': 'Aaron', 'email': 'aaron@10gen.com'}

Message: SERVER-1900 disable test
http://github.com/mongodb/mongo/commit/655a76b8fa2ec18aeb93df5ceb803690f0ed9f20

Comment by auto [ 06/Oct/10 ]

Author:

{'login': 'astaple', 'name': 'Aaron', 'email': 'aaron@10gen.com'}

Message: SERVER-1900 disable test until fixed
http://github.com/mongodb/mongo/commit/1e90166fc7d720017d1878ca085b2c9856d85f9c

Generated at Thu Feb 08 02:58:23 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.