[SERVER-19092] ConnectionPool's per-host list ends up with deleted connections Created: 23/Jun/15  Updated: 10/Apr/22  Resolved: 29/Sep/15

Status: Closed
Project: Core Server
Component/s: Networking
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Critical - P2
Reporter: Kaloian Manassiev Assignee: Andy Schwerin
Resolution: Won't Fix Votes: 0
Labels: todo_in_code
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Depends
Duplicate
is duplicated by SERVER-20618 Brief network connectivity issue led ... Closed
Related
related to SERVER-43430 Complete TODO listed in SERVER-19092 Backlog
related to SERVER-65414 Complete TODO listed in SERVER-19092 Needs Scheduling
Operating System: ALL
Steps To Reproduce:

It is non-deterministic, but seems to happen more frequently if the cleanup interval is lowered:

const Seconds kCleanUpInterval(2);  // Note: Must be larger than kMaxConnectionAge below)
const Seconds kMaxConnectionAge(1);

Only happens in the optimized build. Command line to run the test:

buildscripts\resmoke.py jstests/concurrency/fsm_all_sharded_replication.js > output.log

Sprint: Sharding A (10/09/15)
Participants:
Linked BF Score: 0

 Description   

The ConnectionPool class is used by both replication and sharding. The sharding FSM tests when run sufficiently long encounter a bug where a deleted entry appears in the per-client pool.



 Comments   
Comment by Andy Schwerin [ 29/Sep/15 ]

The connection pool in question is scheduled for removal before the release of 3.2. Its only user is NetworkInterfaceImpl, which is superseded by NetworkInterfaceASIO.

Comment by Andy Schwerin [ 25/Sep/15 ]

As soon as we delete the code.

Comment by Adam Midvidy [ 25/Sep/15 ]

Now that ASIO is the default in master and has been relatively stable in evergreen, can we close this as 'Gone Away' ?

Comment by Githook User [ 24/Jun/15 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-19092 Increase the connection pool cleanup interval

This change is just a workaround until we discover the underlying cause.
Branch: master
https://github.com/mongodb/mongo/commit/92750368e7a65031f4545d7c52ba268033b94a74

Comment by Githook User [ 24/Jun/15 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-19092 Cleanup connection pool

Remove some unused code and make fields constant. No functional change.
Branch: master
https://github.com/mongodb/mongo/commit/34549ae64ad1cd40c3c9652dbc384768633b18f9

Generated at Thu Feb 08 03:49:48 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.