[SERVER-19354] Evaluate applicability of current set of warning suppressions Created: 10/Jul/15  Updated: 07/Aug/23  Resolved: 07/Aug/23

Status: Closed
Project: Core Server
Component/s: Build
Affects Version/s: None
Fix Version/s: None

Type: Task Priority: Major - P3
Reporter: Andrew Morrow (Inactive) Assignee: [DO NOT ASSIGN] Backlog - Server Development Platform Team (SDP) (Inactive)
Resolution: Won't Do Votes: 0
Labels: build-jbr, platforms-re-triaged
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Server Development Platform
Backwards Compatibility: Fully Compatible
Participants:

 Description   

We have a fair number of compiler warnings that we disable, often checking whether the compiler honors the flag with AddToXXXFlagsIfSupported. Currently, that list is:

  • -Wno-unused-local-typedefs
  • -Wno-unused-function
  • -Wno-unused-private-field
  • -Wno-deprecated-declarations
  • -Wno-unused-const-variable
  • -Wno-unused-but-set-variable
  • -Wno-missing-braces
  • -Wno-inconsistent-missing-override
  • -Wno-potentially-evaluated-expression

Some of these flags were added to work around compiler bugs in older versions of GCC or clang, however, we now have compiler minima that are newer than those buggy versions. Others were set to work around bugs or flaws in particular versions of third parth libraries that we use (v8, boost), but in some cases we are now using a newer version of that library, or are replaceing the library entirely. Finally, in other cases, the flag is really only needed for the third_party directory, but we apply it to src/mongo as well, weakening our error checking.

We should audit these flags after our next boost ugprade and a potential switch to SpiderMonkey, and remove those that are no longer required with our compilers or libraries, and scope the ones that are necessary as narrowly as possible.



 Comments   
Comment by Eric Milkie [ 10/Jul/15 ]

We should include the list of Visual Studio warning suppressions as well, while we're at it. It would be nice to promote warnings to errors there.

Generated at Thu Feb 08 03:50:41 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.