[SERVER-19380] asio::ip::tcp::resolver::iterator instances should be passed by value Created: 13/Jul/15 Updated: 31/Aug/15 Resolved: 23/Jul/15 |
|
| Status: | Closed |
| Project: | Core Server |
| Component/s: | Internal Code, Networking |
| Affects Version/s: | None |
| Fix Version/s: | 3.1.7 |
| Type: | Bug | Priority: | Major - P3 |
| Reporter: | Adam Midvidy | Assignee: | Adam Midvidy |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Backwards Compatibility: | Fully Compatible |
| Operating System: | ALL |
| Sprint: | Platform 8 08/28/15, Platform 7 08/10/15 |
| Participants: |
| Description |
|
Currently we capture resolver iterators by reference then pass them to callbacks - potentially leading to dangling references. Internally, the iterator maintains a shared_ptr to the vector of basic_resolver_entry objects. We should pass the iterator by value to make sure the basic_resolver_entry vector stays alive. |
| Comments |
| Comment by Adam Midvidy [ 23/Jul/15 ] |
|
fixed as part of SSL work. |