[SERVER-19391] BSONObjBuilder::appendAsNumber is unused. Created: 14/Jul/15  Updated: 19/Sep/15  Resolved: 23/Jul/15

Status: Closed
Project: Core Server
Component/s: Internal Code
Affects Version/s: None
Fix Version/s: 3.1.7

Type: Improvement Priority: Major - P3
Reporter: David Hatch Assignee: David Hatch
Resolution: Done Votes: 0
Labels: dnsf
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Participants:

 Description   

This method is unused, since https://github.com/mongodb/mongo/commit/4b033ae930afded6677c19022341241935992b33.

A git grep 'appendAsNumber' on master reveals:

src/mongo/bson/bsonobjbuilder.cpp:bool BSONObjBuilder::appendAsNumber(StringData fieldName, const string& data) {
src/mongo/bson/bsonobjbuilder.h:    bool appendAsNumber(StringData fieldName, const std::string& data);
src/mongo/dbtests/jsobjtests.cpp:        ASSERT(b.appendAsNumber("a", "1"));
src/mongo/dbtests/jsobjtests.cpp:        ASSERT(b.appendAsNumber("b", "1.1"));
src/mongo/dbtests/jsobjtests.cpp:        ASSERT(b.appendAsNumber("c", "-1"));
src/mongo/dbtests/jsobjtests.cpp:        ASSERT(b.appendAsNumber("d", "-1.1"));
src/mongo/dbtests/jsobjtests.cpp:        ASSERT(b.appendAsNumber("e", "32131231231232313"));
src/mongo/dbtests/jsobjtests.cpp:        ASSERT(!b.appendAsNumber("f", "zz"));
src/mongo/dbtests/jsobjtests.cpp:        ASSERT(!b.appendAsNumber("f", "5zz"));
src/mongo/dbtests/jsobjtests.cpp:        ASSERT(!b.appendAsNumber("f", "zz5"));



 Comments   
Comment by Githook User [ 28/Jul/15 ]

Author:

{u'username': u'dhatch', u'name': u'David Hatch', u'email': u'david.hatch@mongodb.com'}

Message: SERVER-19391: Remove BSONObjBuilder::appendAsNumber.
Branch: master
https://github.com/mongodb/mongo/commit/d065c380ffc76fef63cf2fe7bacc439134ab39eb

Comment by Githook User [ 23/Jul/15 ]

Author:

{u'username': u'dhatch', u'name': u'David Hatch', u'email': u'david.hatch@mongodb.com'}

Message: SERVER-19391: Remove BSONObjBuilder::appendAsNumber.
Branch: master
https://github.com/mongodb/mongo/commit/d065c380ffc76fef63cf2fe7bacc439134ab39eb

Generated at Thu Feb 08 03:50:48 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.