[SERVER-19500] Make cluster write commands explain to be shard version aware Created: 20/Jul/15  Updated: 06/Dec/22

Status: Backlog
Project: Core Server
Component/s: Sharding, Write Ops
Affects Version/s: None
Fix Version/s: None

Type: Improvement Priority: Major - P3
Reporter: Kaloian Manassiev Assignee: Backlog - Query Execution
Resolution: Unresolved Votes: 0
Labels: query-44-grooming
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Assigned Teams:
Query Execution
Participants:

 Description   

The sharded write commands explain logic should be sending the chunk version as part of the command and mongod should not be ignoring it.



 Comments   
Comment by Githook User [ 28/Jul/15 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-19500 Remove shard version checking for write command explain

Currently the write commands explain code calls
ensureShardVersionOKOrThrow, which performs legacy style shard version
checking based on the contents of the connection. This however does not
have any effect, because write commands are not sent over versioned
connections, so effectively write command explain is non-sharding aware
currently.

This change removes this check for the explain commands.
Branch: master
https://github.com/mongodb/mongo/commit/a69663922c5e02c144ac0cf3139cba22dd8ddefb

Comment by Githook User [ 28/Jul/15 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-19500 Cleanup explain logic

No functional changes, just moving code around.
Branch: master
https://github.com/mongodb/mongo/commit/8f618d4928c1d44abacc8a48d5f398afc6cbdf80

Comment by Githook User [ 21/Jul/15 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-19500 Remove shard version checking for write command explain

Currently the write commands explain code calls
ensureShardVersionOKOrThrow, which performs legacy style shard version
checking based on the contents of the connection. This however does not
have any effect, because write commands are not sent over versioned
connections, so effectively write command explain is non-sharding aware
currently.

This change removes this check for the explain commands.
Branch: master
https://github.com/mongodb/mongo/commit/a69663922c5e02c144ac0cf3139cba22dd8ddefb

Comment by Githook User [ 21/Jul/15 ]

Author:

{u'username': u'kaloianm', u'name': u'Kaloian Manassiev', u'email': u'kaloian.manassiev@mongodb.com'}

Message: SERVER-19500 Cleanup explain logic

No functional changes, just moving code around.
Branch: master
https://github.com/mongodb/mongo/commit/8f618d4928c1d44abacc8a48d5f398afc6cbdf80

Generated at Thu Feb 08 03:51:11 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.