[SERVER-19741] WriteError and WriteConcernError are not Error instances Created: 03/Aug/15  Updated: 13/Aug/16  Resolved: 10/Aug/16

Status: Closed
Project: Core Server
Component/s: Shell
Affects Version/s: 3.1.6
Fix Version/s: 3.3.11

Type: Task Priority: Major - P3
Reporter: Max Hirschhorn Assignee: Waley Chen
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Backwards Compatibility: Fully Compatible
Sprint: Build B (10/30/15), Build C (11/20/15), Platforms 2016-08-26
Participants:

 Description   

There is code in bulk_api.js to set Error.prototype in BulkWriteError instances' prototype chain.

BulkWriteError.prototype = new Error();
BulkWriteError.prototype.constructor = BulkWriteError;

We should do the similar logic for WriteError and WriteConcernError so that the underlying WriteError of a BulkWriteError can be rethrown and still have a stack trace.



 Comments   
Comment by Githook User [ 10/Aug/16 ]

Author:

{u'username': u'WaleyChen', u'name': u'Waley Chen', u'email': u'waleycz@gmail.com'}

Message: SERVER-19741 WriteError and WriteConcernError are not Error instances
Branch: master
https://github.com/mongodb/mongo/commit/df2dacb8a92ac0a5f42b7e40a848c8074940ef2d

Comment by Githook User [ 08/Aug/16 ]

Author:

{u'username': u'WaleyChen', u'name': u'Waley Chen', u'email': u'waleycz@gmail.com'}

Message: Revert "SERVER-19741 WriteError and WriteConcernError are not Error instances"

This reverts commit f800685a05002ada9388d1fdfd84046ec6dccf70.
Branch: master
https://github.com/mongodb/mongo/commit/11394b9e5d77613ddc4e9abaaf5caa82c9128fa2

Comment by Githook User [ 08/Aug/16 ]

Author:

{u'username': u'WaleyChen', u'name': u'Waley Chen', u'email': u'waleycz@gmail.com'}

Message: SERVER-19741 WriteError and WriteConcernError are not Error instances
Branch: master
https://github.com/mongodb/mongo/commit/f800685a05002ada9388d1fdfd84046ec6dccf70

Generated at Thu Feb 08 03:51:55 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.