[SERVER-19862] authentication code should not depend on DBClient Created: 11/Aug/15  Updated: 31/Aug/15  Resolved: 12/Aug/15

Status: Closed
Project: Core Server
Component/s: Networking, Security
Affects Version/s: 3.1.7
Fix Version/s: 3.1.7

Type: Bug Priority: Major - P3
Reporter: Samantha Ritter (Inactive) Assignee: Samantha Ritter (Inactive)
Resolution: Done Votes: 0
Labels: networking
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Related
is related to SERVER-19155 async auth support in NetworkInterfac... Closed
Backwards Compatibility: Fully Compatible
Operating System: ALL
Sprint: Platform 8 08/28/15
Participants:

 Description   

The "authcommon" target has a dependency on DBClient because of the following method:

bool authenticateInternalUser(DBClientWithCommands* conn);

authenticateInternalUser() should become a method on the DBClientWithCommands class so DBClient depends on the auth code and not the other way around.



 Comments   
Comment by Samantha Ritter (Inactive) [ 12/Aug/15 ]

This mis-labeled commit fixes this issue: https://github.com/mongodb/mongo/commit/da780777b278314d7820483882af014b7b773547

Comment by Samantha Ritter (Inactive) [ 11/Aug/15 ]

In order to authenticate, NetworkInterfaceASIO relies on the "authcommon" target. It seems wrong to introduce a dependency on DBClient here.

Generated at Thu Feb 08 03:52:18 UTC 2024 using Jira 9.7.1#970001-sha1:2222b88b221c4928ef0de3161136cc90c8356a66.